Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyku v6.0.0 release #2260

Merged
merged 9 commits into from
Jul 5, 2024
Merged

Hyku v6.0.0 release #2260

merged 9 commits into from
Jul 5, 2024

Conversation

laritakr
Copy link
Collaborator

Updates Hyrax to main branch now that double_combo is merged, and pulls in IiifPrint update.

Fixes scientist-softserv/palni_palci_knapsack#102

@laritakr
Update gems
12fe02d 
Updates Hyrax to main branch, and pulls in IiifPrint update.
@laritakr laritakr added patch-ver for release notes ignore-for-release ignore this for release notes and removed patch-ver for release notes labels Jun 25, 2024
kirkkwang
kirkkwang previously approved these changes Jun 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   17m 45s ⏱️ -25s
2 027 tests ±0  1 977 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 054 runs  ±0  2 002 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 04fb1a8. ± Comparison against base commit f7e9a0d.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. 
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 6ae0bdf5-9acd-41a5-8240-2930c0d6b61d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b481e9cc-ff60-4f66-af84-4d569a0cccf9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f1ab12e5-d953-4e17-a020-4b94c06ed89d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 435ff538-36a2-4029-927b-edea5fa0fc7f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4deedf7a-ca96-48b0-a650-d65ad8b2107c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4b07ab26-936f-47d1-bd8b-88ef841fc890
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read c0236712-d3cb-4323-92d8-8fd8932b5057
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 694ec22e-b352-41f5-9316-00b759401fa6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 533193b0-6f5e-4f75-8bea-b5209892afeb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 4c7fe9b3-1f4a-4dee-b259-a44847fa1a70
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy dfd614c5-8136-4e4c-b5cc-31609c34eb16
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 236c324c-2ba9-4fc2-a65a-43d3ca306f34
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d6d10a5e-bf07-4c81-9d01-d2f4b921ff68
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update adc6c99f-83ec-478e-a088-465c6895ed7b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 894db480-c38c-42fe-a4f5-c522b0b4dd7d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c077da12-2b6b-49c8-bf11-8d7435f56c6b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1a39e214-7cc1-4674-b19b-f3a8e05e6497
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update fe582625-e2fc-4fc3-8bf5-591cbcef9054
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 25cbaa85-b259-4048-93f0-94536a71a770
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 169c0e81-7d1d-45a5-9d07-6079ad5bd83b
…

♻️ This comment has been updated with latest results.

ShanaLMoore
ShanaLMoore reviewed Jun 26, 2024
View reviewed changes
Gemfile Show resolved Hide resolved
This was referenced Jun 26, 2024
Closed
Open
@jillpe jillpe mentioned this pull request Jun 27, 2024
Open
6 tasks
@kirkkwang
Fix flaky user_spec
7eb65b4 
This spec would fail on the first of the month.  To account for that, we
freeze the time.
@kirkkwang
Fix flaky _user_util_links spec leakage
d0022dd 
This spec was leaking into the user_roles spec because the Login would
sometimes be disabled going into the next spec.
@kirkkwang
Fix flaky rake_spec
ad6371c 
The migrate_hyku_commons_collection_thumbnails_to_valkyrie_spec also had
a Rails.application.load_tasks which would break rake_spec if it ran
after.  This is fixed by adding a guard.
@kirkkwang
Fix flaky create_large_derivatives_job spec
3b7906a 
The tenant_config spec was setting default_pdf_viewer to `false` which
leaked out to other tests after it.
@kirkkwang
Add Hyrax::SolrDocumentBehaviorDecorator
d6bc24a 
This can be removed once samvera/hyrax#6860 is
merged and Hyrax is updated.
@ShanaLMoore ShanaLMoore changed the title Update gems Hyku v6.0.0 release Jul 3, 2024
@kirkkwang
Add explicit requires for riiif constants
e890b9f 
In development we were seeing the Universal Viewer locking up the entire
web service when trying to load certain riiif constants.  This commit
will load those contants beforehand in an initializer.
ShanaLMoore
ShanaLMoore previously approved these changes Jul 5, 2024
View reviewed changes
@kirkkwang
Update more gems
04fb1a8 
This commit will update Rails to an actual released version instead of
the 6_1 stable.  IIIF Print 3.0.1 has also been released so we are using
that as well.

Update IIIF Print
@kirkkwang kirkkwang merged commit 5b80a96 into main Jul 5, 2024
9 checks passed
@kirkkwang kirkkwang deleted the update-gems branch July 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShanaLMoore ShanaLMoore ShanaLMoore approved these changes

@kirkkwang kirkkwang kirkkwang left review comments

Assignees
No one assigned
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iiif Print is not splitting for Pals Knapsack
3 participants
@laritakr @ShanaLMoore @kirkkwang