Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NavBar & Header #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix NavBar & Header #372

wants to merge 1 commit into from

Conversation

saras-69
Copy link
Contributor

Description
This PR adjusts the height of the NavBar & Header components to ensure a consistent and responsive layout using 10vh. It resolves any overlapping issues and improves the scrolling experience.

Related Issues
Closes : #281 (comment)

Before:

Screen.Recording.2024-10-18.202100.mp4

And Logo was not fix and header and navbar component get scroll

After:

Screen.Recording.2024-10-18.201410.mp4

Additional Context
This fix improves the header and navbar behavior across devices by using 10vh to maintain responsiveness and prevent UI shifts during scrolling.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eventmint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:54pm

@samyakmaitre
Copy link
Owner

scroll is not smooth.

@saras-69
Copy link
Contributor Author

scroll is not smooth.

Because there is two different components if want smooth I'll fix this

@samyakmaitre
Copy link
Owner

yes please

@saras-69
Copy link
Contributor Author

scroll is not smooth.

Because there is two different components if want smooth I'll fix this

It will become smooth when I change 10vh to 100 vh

@saras-69
Copy link
Contributor Author

yes please

Can please add level3 in my previous pr for pasword recovery page🥹

@samyakmaitre
Copy link
Owner

Was it able to send mail for recovery?

@saras-69
Copy link
Contributor Author

Was it able to send mail for recovery
No, for that You have to set up an SMTP server (like Gmail SMTP, SendGrid, or Nodemailer in Node.js)

@saras-69
Copy link
Contributor Author

For that I will create seprate issue

@samyakmaitre
Copy link
Owner

Thats why, you have more labels from my side right.....and more incoming too

@saras-69
Copy link
Contributor Author

Thats why, you have more labels from my side right.....and more incoming too

Okay 😊

Copy link
Owner

@samyakmaitre samyakmaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Reviewed

Copy link
Owner

@samyakmaitre samyakmaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder,
Scroll not smooth
also resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants