-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix NavBar & Header #372
base: main
Are you sure you want to change the base?
fix NavBar & Header #372
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scroll is not smooth. |
Because there is two different components if want smooth I'll fix this |
yes please |
It will become smooth when I change 10vh to 100 vh |
Can please add level3 in my previous pr for pasword recovery page🥹 |
Was it able to send mail for recovery? |
|
For that I will create seprate issue |
Thats why, you have more labels from my side right.....and more incoming too |
Okay 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder,
Scroll not smooth
also resolve conflicts
Description
This PR adjusts the height of the NavBar & Header components to ensure a consistent and responsive layout using 10vh. It resolves any overlapping issues and improves the scrolling experience.
Related Issues
Closes : #281 (comment)
Before:
Screen.Recording.2024-10-18.202100.mp4
And Logo was not fix and header and navbar component get scroll
After:
Screen.Recording.2024-10-18.201410.mp4
Additional Context
This fix improves the header and navbar behavior across devices by using 10vh to maintain responsiveness and prevent UI shifts during scrolling.