feat(device) detect new brand Senkatel models: T8002, T1009, T7011, T…

…7012, T9702 feat(device) detect brand DNS model: SD01M issue matomo-org#6355
sanchezzzhak · Aug 22, 2020 · 0fed319 · 0fed319
1 parent 37ff379
commit 0fed319
Show file tree

Hide file tree

Showing 3 changed files with 130 additions and 4 deletions.
diff --git a/Parser/Device/DeviceParserAbstract.php b/Parser/Device/DeviceParserAbstract.php
@@ -571,6 +571,7 @@ abstract class DeviceParserAbstract extends ParserAbstract
         'SD' => 'Sega',
         'SL' => 'Selfix',
         'SE' => 'Sony Ericsson',
+        '01' => 'Senkatel',
         'S1' => 'Sencor',
         'SF' => 'Softbank',
         'SX' => 'SFR',

diff --git a/Tests/fixtures/smartphone-16.yml b/Tests/fixtures/smartphone-16.yml
@@ -5239,3 +5239,123 @@
     model: MOMO Mini 3GS
   os_family: Android
   browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.1.2; SD01M Build/JZO54K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.99 Mobile Safari/537.36 OPR/50.3.2426.136976
+  os:
+    name: Android
+    short_name: AND
+    version: 4.1.2
+    platform: ""
+  client:
+    type: browser
+    name: Opera Mobile
+    short_name: OM
+    version: 50.3.2426.136976
+    engine: Blink
+    engine_version: ""
+  device:
+    type: smartphone
+    brand: DN
+    model: SD01M
+  os_family: Android
+  browser_family: Opera
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.1.2; Senkatel_T8002 Build/JZO54K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: 4.1.2
+    platform: ""
+  client:
+    type: browser
+    name: Chrome
+    short_name: CH
+    version: 67.0.3396.87
+    engine: Blink
+    engine_version: ""
+  device:
+    type: tablet
+    brand: "01"
+    model: T8002
+  os_family: Android
+  browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.2.2; Senkatel T7012 Build/JDQ39) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.111 Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: 4.2.2
+    platform: ""
+  client:
+    type: browser
+    name: Chrome
+    short_name: CH
+    version: 42.0.2311.111
+    engine: Blink
+    engine_version: ""
+  device:
+    type: tablet
+    brand: "01"
+    model: T7012
+  os_family: Android
+  browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.2.2; Senkatel_T7011 Build/JDQ39) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: 4.2.2
+    platform: ""
+  client:
+    type: browser
+    name: Chrome
+    short_name: CH
+    version: 67.0.3396.87
+    engine: Blink
+    engine_version: ""
+  device:
+    type: tablet
+    brand: "01"
+    model: T7011
+  os_family: Android
+  browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.1.1; Senkatel_T1009 Build/JRO03C) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: 4.1.1
+    platform: ""
+  client:
+    type: browser
+    name: Chrome
+    short_name: CH
+    version: 69.0.3497.100
+    engine: Blink
+    engine_version: ""
+  device:
+    type: tablet
+    brand: "01"
+    model: T1009
+  os_family: Android
+  browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.1.1; Senkatel_T9702 Build/JRO03H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.99 Safari/537.36 OPR/50.3.2426.136976
+  os:
+    name: Android
+    short_name: AND
+    version: 4.1.1
+    platform: ""
+  client:
+    type: browser
+    name: Opera
+    short_name: OP
+    version: 50.3.2426.136976
+    engine: Blink
+    engine_version: ""
+  device:
+    type: tablet
+    brand: "01"
+    model: T9702
+  os_family: Android
+  browser_family: Opera
diff --git a/regexes/device/mobiles.yml b/regexes/device/mobiles.yml
@@ -3978,11 +3978,11 @@ Doro:
 
 # DNS
 DNS:
-  regex: '(?:DNS|AirTab)[ _\-]([^;/]+)Build|S4505M[);/ ]'
+  regex: '(?:DNS|AirTab)[ _\-]([^;/]+)Build|(?:S4505M|SD01M)[);/ ]'
   device: 'smartphone'
   models:
-    - regex: 'S4505M[);/ ]'
-      model: 'S4505M'
+    - regex: '(S4505M|SD01M)[);/ ]'
+      model: '$1'
     - regex: 'AirTab[ _\-]([^;/]+)Build'
       model: 'AirTab $1'
       device: 'tablet'
@@ -15915,4 +15915,9 @@ Eltex:
     - regex: 'NV501WAC[);/ ]'
       model: 'NV-501-Wac'
     - regex: 'NV501[);/ ]'
-      model: 'NV-501'
+      model: 'NV-501'
+
+Senkatel:
+  regex: 'Senkatel[ _](T1009|T8002|T701[12]|T9702)[);/ ]'
+  device: 'tablet'
+  model: '$1'