-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To check everything is OK before submission of v5 #11
base: master
Are you sure you want to change the base?
Conversation
I tweaked the message above. Running FATE results in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FATE fails
Many thanks. I will change the commit message for the submission.
I just remembered that I need to remove 'GEN=1' option with the FATE test. It's my bad :( Apparently, I have to change I will update |
Yes! |
Ok, I will tackle this today. I hope it won't take long. |
I have updated the test code The results ( |
The FATE tests on HEAD are OK. I will send this patch to you first, just in case, and then to the FFMPEG-devel. |
…fined in ISO/IEC 15444-4 Fix for the integer version of the inverse 9-7 DWT processing (FF_DWT97_INT, https://trac.ffmpeg.org/ticket/10123), which is activated with `-flags +bitexact`. I went through the code path for the DWT 9-7 transform (integer) and improved precision to match conformance codestream. As a result, the encoded codestream size is slightly larger for a given Q value. For example, `-flags +bitexact -i lena.pnm -q: 20 -format j2k -y tmp.j2c` gives 13K (HEAD) and 19K (with this patch). This commit also updates the source and reference files for affected FATE tests.
... I was running test and, evidently, the change in step size affects both bitexact and not bitexact. This, as you note, result in a change of file size given a particular Q value. I am asking since the patch is intended to address the bitexact bug, but somehow it is also affecting all code paths. Is there a way for the patch to affect only the |
298f3ab
to
0f3b233
Compare
Please review the following commit message.
avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4
Fix for the integer version of the inverse 9-7 DWT processing (FF_DWT97_INT, https://trac.ffmpeg.org/ticket/10123), which is activated with
-flags +bitexact
. I went through the code path for the DWT 9-7 transform (integer) and improved precision to match conformance codestream. As a result, the encoded codestream size is slightly larger for a given Q value. For example,-flags +bitexact -i lena.pnm -q: 20 -format j2k -y tmp.j2c
gives 13K (HEAD) and 19K (with this patch).This commit also updates the reference files for affected FATE tests.