Patches/placeholder passes v8 local #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for CAP and CPF markers. Decoding will exit when encountering Ilegal input codestreams.
This commit adds support for placeholder pass parsing.
palemieux
requested changes
Aug 6, 2024
libavcodec/jpeg2000htdec.c
Outdated
| modify_state = block_states[(i + 1) * stride + (j + 1)]; | ||
| modify_state |= 1 << HT_SHIFT_SCAN; | ||
| if (mbr != 0) { | ||
| modify_state |= 1 << HT_SHIFT_REF_IND; |
There was a problem hiding this comment.
Trailing space.
In VSCode you can search for +$ to select them.
There was a problem hiding this comment.
Thanks for cathing this.
This commit fixes wrong treatment of MAGBP value in Ccap15 and bugs in HT block decoding.
osamu620
force-pushed
the
patches/placeholder-passes-v8-local
branch
from
e4acecf
to
58ad780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion. The updated patch set has not yet been sent to the FFMPEG-devel.
Suggestions in #4 have been accepted except for the one for
(This was the original code)