Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 4: Pioneer WEC #243

Merged
merged 90 commits into from
Jul 13, 2023

Conversation

michaelcdevin
Copy link
Collaborator

Description

Tutorial showcasing the Pioneer WEC: https://github.com/SNL-WaterPower/pioneer_wec

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: Tutorial

Checklist for PR

@michaelcdevin michaelcdevin self-assigned this May 25, 2023
@coveralls
Copy link

coveralls commented May 25, 2023

Pull Request Test Coverage Report for Build 5395073842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 2 files are covered.
  • 29 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 92.609%

Files with Coverage Reduction New Missed Lines %
wecopttool/core.py 29 91.81%
Totals Coverage Status
Change from base Build 5035956975: 0.0%
Covered Lines: 2481
Relevant Lines: 2679

💛 - Coveralls

@michaelcdevin
Copy link
Collaborator Author

Positions amplitudes and phases are nearly matching in the verification case, though WecOptTool is still having a slight change in amplitude for some reason. PTO velocity is still twice what it is in Mark's Python script, but the mean power is about half?

WecOptTool:
image

Mark's script:
comparison_2500MaxTrq_pos
comparison_2500MaxTrq_vel

@michaelcdevin
Copy link
Collaborator Author

After some more tweaks, all the positions are lining up with Mark's reference script, but the velocity in WecOptTool is not lining up with its position for some reason... still investigating this.
image

docs/source/tutorials.rst Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
@michaelcdevin michaelcdevin marked this pull request as ready for review July 13, 2023 05:04
@cmichelenstrofer cmichelenstrofer merged commit b4a7aec into sandialabs:main Jul 13, 2023
10 checks passed
@michaelcdevin michaelcdevin deleted the tutorial_4_Pioneer branch October 25, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants