Fix CI random failures #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcdevin
commented
Oct 11, 2023
| rtol=rtol, atol=atol, equal_nan=equal_nan) | ||
| if np.sum(a_in_b) == 1: | ||
| ind.append(np.flatnonzero(a_in_b)[0]) | ||
| if np.sum(a_in_b) > 1: |
There was a problem hiding this comment.
subset_close is only ever used to confirm the wave elevation directions are all included in the list of excitation coefficient directions, so I figured taking the nearest value is the best solution. I highly doubt this ever becomes an issue if using the normal WecOptTool workflow, but I think it's good to have.
michaelcdevin
added
bug
michaelcdevin
force-pushed
the
bug/random_ci_failure_fix
branch
from
3bc805e
to
6b32ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #245 (and makes the call to
subset_closearound an order of magnitude faster).Type of PR
Checklist for PR