-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup regressions #132
Cleanup regressions #132
Conversation
* Once we have full linting coverage this can be its own stage but for now run the pytest hack with list of covered files.
Is there a reason we moved away from just calling coveralls directly? That coveralls github action has an issue open specifically related to it having issues with python. They point to this python specific package to support https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support |
Here's an example of what's happening in coveralls when including the file docstring at the top; the class docstring appears as uncovered "code". If there is a problem with coveralls, we could consider moving to another code coverage tool; I am not too fluent in what's available. |
Here's the example: https://coveralls.io/builds/60539470/source?filename=pyttb%2Fktensor.py |
If I understand correctly it's our GitHub action integration with coveralls rather than coveralls itself. Feel free to assign an issue to me to investigate or I'll file one later this week. |
Here's the output of running coveralls directly in a clean conda env locally with these updates: https://coveralls.io/jobs/122739175 This was run using the following (per coveralls docs):
|
I could not get this to run with this level of coverage unless I created a new conda env. So, I think we may want to be more strict about our minimum versions of dependencies that we use for development. |
Test if we can resolve this #131 (comment)
Revert some changes, enforce pylint, and fix a bug because windows path representation is silly.