Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple connections for Emacs-26 and below #34

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

bbuccianti
Copy link
Contributor

I don't understand entirely monroe-net-filter, but after a lot of debugging on emacs 26.3 and emacs 27.0.91, I came to the conclusion that ignore-errors was causing that monroe doesn't dispatch all decoded messages. I think this fixes the issue with previous versions of emacs, although I would really like that folks test it.

Cheers!

@bbuccianti
Copy link
Contributor Author

I think the error about a non existent hash-table-empty-p function has been solved definitely in last commit.

@bbuccianti
Copy link
Contributor Author

Maybe I didn't explained the changes properly. I'm telling that ignore-errors was causing that monroe doesn't dispatch all decoded messages but that's half the true. It seems that ignore-errors was hiding the actual error, which is that hash-table-empty-p function wasn't when there when needed. That's why, after (require 'subr-x) the problem has gone. I think that with-demoted-errors macro help us to avoid in the future if some kind of error happen, we can now for sure what's happening. With ignore-errors was really hard for me to lookup what was happening.

@bbuccianti
Copy link
Contributor Author

@sanel can you test on emacs 26.3?

@bbuccianti bbuccianti changed the title Avoid ignore-errors in monroe-net-filter Fix multiple connections for Emacs-26 and below Sep 25, 2020
@bbuccianti
Copy link
Contributor Author

Maybe this commit messages has better explanations than before.

@sanel
Copy link
Owner

sanel commented Aug 24, 2021

Sorry @bbuccianti for delayed reply. I'll merge this and see how it works

@sanel
Copy link
Owner

sanel commented Aug 24, 2021

Thanks!

@sanel sanel merged commit d140512 into sanel:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants