'interfaces' on interface should be an empty list #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
commented
Feb 9, 2023
| @@ -272,7 +272,7 @@ package object introspection { | |||
| "interfaces", | |||
| OptionType(ListType(__Type)), | |||
| resolve = _.value._2 match { | |||
| case t: ObjectType[_, _] => | |||
| case t: ObjectLikeType[_, _] => | |||
There was a problem hiding this comment.
ObjectLikeType regroups ObjectType and InterfaceType
yanns
added a commit
that referenced
this pull request
Feb 10, 2023
The change #960 introduces some support for interfaces of interface. But this feature is not complete: it would need something like #597 for full support. Right now, sometimes we support interfaces of interface and sometimes now. To avoid this configuration, let's always return an empty list. We can tackle the complete support for interfaces of interface later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #956
Steps to reproduce:
returns:
but according to specs it should return:
More details: https://spec.graphql.org/October2021/#sec-The-__Type-Type.Interface
Knowing that sangria does not support interfaces of interfaces for now, we just change the introspection result to render an empty array instead of null.