Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types ScheduledPublishingPluginOptions and BetaFeatures #7637

Closed
saiichihashimoto opened this issue Oct 19, 2024 · 0 comments · Fixed by #7659
Closed

Export types ScheduledPublishingPluginOptions and BetaFeatures #7637

saiichihashimoto opened this issue Oct 19, 2024 · 0 comments · Fixed by #7659
Assignees

Comments

@saiichihashimoto
Copy link
Contributor

saiichihashimoto commented Oct 19, 2024

Describe the bug

The types ScheduledPublishingPluginOptions and BetaFeatures aren't exported, which makes it impossible to reexport the defineConfig.

To Reproduce

Steps to reproduce the behavior:

I'm working on sanity-typed, so all of these things are within that repo

  1. Update sanity to 3.61.0 (or anything past 3.38.0).
  2. npm install
  3. npm build, watch it break.
  4. (If I go into packages/types/node_modules/sanity/lib/index.d.ts and change declare interface ScheduledPublishingPluginOptions to export interface ScheduledPublishingPluginOptions, everything works)

Expected behavior

For builds re-exporting defineConfig not to break

Screenshots

@sanity-typed/types:build: src/internal.ts(1324,14): error TS4023: Exported variable 'defineConfig' has or is using name 'ScheduledPublishingPluginOptions' from external module "/Users/shayan/Workspace/sanity-typed/node_modules/sanity/lib/index" but cannot be named.
@sanity-typed/types:build: src/internal.ts(1324,14): error TS4023: Exported variable 'defineConfig' has or is using name 'BetaFeatures' from external module "/Users/shayan/Workspace/sanity-typed/node_modules/sanity/lib/index" but cannot be named.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants