Validate array type of types for object without a name when used in combination with a block type #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
force-pushed
the
validate-array-type-for-name
branch
from
a9c50bd
to
3c65c11
Compare
skogsmaskin
added a commit
that referenced
this pull request
Jan 31, 2019
…ombination with a block type (#1171) * [default-layout] Fix unique keys and add propTypes for SchemaErrorReporter * [schema] Don't allow object types without a name when used with a block type
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
…ombination with a block type (#1171) * [default-layout] Fix unique keys and add propTypes for SchemaErrorReporter * [schema] Don't allow object types without a name when used with a block type
Merged
skogsmaskin
added a commit
that referenced
this pull request
Feb 1, 2019
…ombination with a block type (#1171) * [default-layout] Fix unique keys and add propTypes for SchemaErrorReporter * [schema] Don't allow object types without a name when used with a block type
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
…ombination with a block type (#1171) * [default-layout] Fix unique keys and add propTypes for SchemaErrorReporter * [schema] Don't allow object types without a name when used with a block type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a type
blockin an array, we must validate that it also doesn't use object types without a name, because the block editor is dependent on all the members having names.In the future we probably should make it an overall requirement that every array member type should have a name.
There is also a commit here that fixes unique keys (we now have warnings) and completes propTypes for the SchemaErrorReporter component.