[form-builder] Show warning on non-object array values #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
requested review from
bjoerge and
mariuslundgard
and removed request for
bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
* [validation] Fix crash on non-object array values * [form-builder] Show warning on non-object array values
Merged
skogsmaskin
pushed a commit
that referenced
this pull request
Feb 1, 2019
* [validation] Fix crash on non-object array values * [form-builder] Show warning on non-object array values
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [validation] Fix crash on non-object array values * [form-builder] Show warning on non-object array values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you somehow end up with
null-values (or other non-object values) inside an array that is supposed to contain objects, the desk tool currently crashes.This PR introduces a check for whether or not this is the case, and allows you to unset the non-object values.