[schema] Allow tel: and mailto: as URI schemes for block link annotation #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will not allow for relative URL's I guess. Maybe it should? |
|
Good question. In a sense, the only "correct" thing for backwards compatibility is to disable validation, but that seems like a bad default for new projects. Thoughts? |
|
I'm in favour of validating, but allowing any kind of URI by default. |
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
…ion (#1178) * [schema] Allow tel: and mailto: as URI schemes for block link annotation * [schema] Allow relative URIs for default link annotation
Merged
skogsmaskin
pushed a commit
that referenced
this pull request
Feb 1, 2019
…ion (#1178) * [schema] Allow tel: and mailto: as URI schemes for block link annotation * [schema] Allow relative URIs for default link annotation
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
…ion (#1178) * [schema] Allow tel: and mailto: as URI schemes for block link annotation * [schema] Allow relative URIs for default link annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did not do any validation on annotations. After the new block editor, we do.
This PR will allow the mailto and tel schemes in the default link annotation.