[form-builder] Use text input for relative URL fields #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
Merged
skogsmaskin
pushed a commit
that referenced
this pull request
Feb 1, 2019
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the annoying case where browsers would show a relative URI as invalid even though the validation allows it.
Refactored the fetching of rules into a separate utility since it's kinda verbose and used in the number input as well.
We should probably revisit the validation implementation given that we now have a clearer picture of the weaker points of its implementation, but will create a separate issue for that.