Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Coerce semver to allow prereleases of React #1182

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 25, 2019

Currently our React version check disallows prereleases of React, which I don't think there are any good reasons to do. This coerces the semver before calling the satisifes check.

For reference

semver.satisfies(semver.coerce('16.8.0-alpha.0'), '^16.2') // true
semver.satisfies(semver.coerce('16.6'), '^16.2') // true
semver.satisfies(semver.coerce('16.1'), '^16.2') // false
semver.satisfies(semver.coerce('17.0.0'), '^16.2') // false

@bjoerge bjoerge requested a review from rexxars January 25, 2019 10:05
@bjoerge bjoerge merged commit 2562cbb into next Jan 25, 2019
@bjoerge bjoerge deleted the allow-react-prerelease branch January 25, 2019 10:32
@skogsmaskin skogsmaskin mentioned this pull request Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants