[base] Create part of referring documents hoc/util-component #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
rexxars
requested changes
Jan 30, 2019
rexxars
approved these changes
Jan 30, 2019
kristofferjs
pushed a commit
that referenced
this pull request
Jan 31, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
It has been rewritten to be a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
The old higher order component behavior is kept in desk tool for now, but should probably be replaced by using `WithReferringDocuments` directly
skogsmaskin
pushed a commit
that referenced
this pull request
Jan 31, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
It has been rewritten to be a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
The old higher order component behavior is kept in desk tool for now, but should probably be replaced by using `WithReferringDocuments` directly
bjoerge
added a commit
that referenced
this pull request
Feb 1, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
bjoerge
added a commit
that referenced
this pull request
Feb 1, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
Merged
skogsmaskin
pushed a commit
that referenced
this pull request
Feb 1, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
bjoerge
added a commit
that referenced
this pull request
Aug 13, 2019
This is a tiny refactor of the `enhanceWithReferringDocuments` utility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.
Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this:
```jsx
import {WithReferringDocuments} from 'part:@sanity/base/with-referring-documents'
function MyComponent(props) {
return (
<WithReferringDocuments id={props.documentId}>
{({isLoading, referringDocuments}) =>
isLoading
? 'Loading referring documents…'
: `Found ${referringDocuments.length} documents referring to ${props.documentId}`
}
</WithReferringDocuments>
)
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny refactor of the
enhanceWithReferringDocumentsutility used in desk tool for fetching a list of document that refers to the one you are attempting to unpublish/delete. Since it is useful for other packages as well, i moved it into base and made a sanity-part of it.Additionally it is usable not only a higher order component, but also as a component that takes a render func as child, so it can be used like this: