Fix various editor bugs and upgrade latest Slate packages #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
force-pushed
the
fix-block-editor-paste-bug
branch
2 times, most recently
from
ce11df3
to
7a89d6f
Compare
skogsmaskin
changed the title
skogsmaskin
force-pushed
the
fix-block-editor-paste-bug
branch
4 times, most recently
from
41d8718
to
34d6b10
Compare
… a set patch Also some code paths optimizations.
skogsmaskin
force-pushed
the
fix-block-editor-paste-bug
branch
from
34d6b10
to
676c65d
Compare
skogsmaskin
changed the title
skogsmaskin
changed the title
skogsmaskin
changed the title
skogsmaskin
added a commit
that referenced
this pull request
Jan 31, 2019
…1189) * [form-builder] Block editor: Prettier fix for Syncwrapper * [form-builder] Block editor: remove unused import * [form-builder] Block editor: add patching test * [form-builder] Block editor: setIfMissing patches must be followed by set * [form-builder] Block editor: fix invalid return values * [form-builder] Block editor: fix triple click bug * [form-builder] Block editor: upgrade slate packages
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
…1189) * [form-builder] Block editor: Prettier fix for Syncwrapper * [form-builder] Block editor: remove unused import * [form-builder] Block editor: add patching test * [form-builder] Block editor: setIfMissing patches must be followed by set * [form-builder] Block editor: fix invalid return values * [form-builder] Block editor: fix triple click bug * [form-builder] Block editor: upgrade slate packages
bjoerge
pushed a commit
that referenced
this pull request
Feb 1, 2019
…1189) * [form-builder] Block editor: Prettier fix for Syncwrapper * [form-builder] Block editor: remove unused import * [form-builder] Block editor: add patching test * [form-builder] Block editor: setIfMissing patches must be followed by set * [form-builder] Block editor: fix invalid return values * [form-builder] Block editor: fix triple click bug * [form-builder] Block editor: upgrade slate packages
Merged
skogsmaskin
added a commit
that referenced
this pull request
Feb 1, 2019
…1189) * [form-builder] Block editor: Prettier fix for Syncwrapper * [form-builder] Block editor: remove unused import * [form-builder] Block editor: add patching test * [form-builder] Block editor: setIfMissing patches must be followed by set * [form-builder] Block editor: fix invalid return values * [form-builder] Block editor: fix triple click bug * [form-builder] Block editor: upgrade slate packages
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
…1189) * [form-builder] Block editor: Prettier fix for Syncwrapper * [form-builder] Block editor: remove unused import * [form-builder] Block editor: add patching test * [form-builder] Block editor: setIfMissing patches must be followed by set * [form-builder] Block editor: fix invalid return values * [form-builder] Block editor: fix triple click bug * [form-builder] Block editor: upgrade slate packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when pasting something into a new and empty editor field because
setIfMissingpatches was not followed by thesetpatches. This lead to twosetIfMissingpatches where the last one didn't apply anything.This is fixed in commit 676c65d
Also added a test, and did a minor code hygiene (own commits).