Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in blockeditor #1416

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Icons in blockeditor #1416

merged 5 commits into from
Jul 8, 2019

Conversation

kristofferjs
Copy link
Contributor

  • Support adding icon directly on blockTypes, annotations and decorators in the same way we add icons on other types
  • Resolve annotation icons from types/references in schema

skogsmaskin
skogsmaskin reviewed Jul 8, 2019
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should probably try to evaluate the need for the blockEditor key now and see if we could get rid of it (though backward comp. must still be there, so this is more a documentation issue).

@kristofferjs
Copy link
Contributor Author

Agreed. In case of ditching the blockEditor key we should throw a warning that it will be deprecated.

skogsmaskin
skogsmaskin approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this one, but let's get back to the documentation / deprecation issues in august. Can you create an issue?

@kristofferjs kristofferjs merged commit 5d1a90b into next Jul 8, 2019
@kristofferjs kristofferjs deleted the icons-in-blockeditor branch July 8, 2019 12:27
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@bjoerge
[form-builder] Icons in blockeditor (#1416)
6a1bfbf 
* [schema] Support icon on block

* [schema] Support annotation icon

* [schema] Support decorator icon

* [form-builder] Resolve annotation icon

* [test-studio] Customised icon test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristofferjs @skogsmaskin