[components] Add new snackbars #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vicmeow
commented
Aug 2, 2019
vicmeow
commented
- Add new snackbar design and functionality for better feedback on user actions
- Makes queuing of snackbars in the studio possible (current max stack of 3)
|
I'd really love to dive into and review this, but unsure how I can find the time to do it properly. Will by Monday work, or do you folks want it out today? |
@thomax Not expecting anything more for this to be done today, so Monday works! |
kristofferjs
suggested changes
Aug 2, 2019
kristofferjs
approved these changes
Aug 6, 2019
thomax
reviewed
Aug 7, 2019
| return activeSnacks.map((snack, index) => { | ||
| const {view: viewOffset, snackbar: snackbarOffset} = {view: 10, snackbar: 12} | ||
| let offset = viewOffset | ||
| while (activeSnacks[index - 1]) { |
There was a problem hiding this comment.
I'm always afraid of while-loops, but I guess that's just my superstition :)
thomax
approved these changes
Aug 7, 2019
|
I'd like to talk to you about extending/changing the snackbar? |
Done :) |
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [snackbar] add new snackbar * [snackbar] put default snackbar back and create provider part * [snackbar] fix old and new parts * [snackbar] update provider part path * [snackbar] add height handler for stack offsets * [snackbar] add action handler * [snackbar] improve naming * [snackbar] add children as props * [snackbar] add context * [snackbar] update styles * [snackbar] make snackbar accessible * [snackbar] linting * [snackbar] add default icons to snacks * [snackbar] refactor provider and item * [snackbar] update DefaultSnackbar.js + its instances * [snackbar] fix persist status * [components] Queue snackbar story * [components] improve var naming * [components] flatten snackbar props * [components] refactor, and improve a11y * [components] refactor and fix transitions * [components] add snackbar stories * [components] refactor props, improve readability * [components] refactor hide and action behaviours * [components] improve snackbar on smaller screens * [components] clear timeouts on unmount * [components] fix css class names and id generator * [components] fix possible message types * [components] dismiss snack on willUnmount * [components] remove danger state * [components] fix default icons * [components] fix tabindex and outline focus * [components] fix icon and content alignment * [components] update storybook * [components] fix close icon color inheritance * [components] fix snackbar styles and sizes * [components] fix with and w/o icon spacing * [components] fix tabindex on snack item * [components] remove transitionDuration as prop * [components] remove another transitionDuration * [components] update with discussed changes * [components] update text and icon alignment * [components] add title and subtitle * [components] fix margins and alignments * [components] update story * [components] simplify story * [components] fix action and close bleed * [components] float action and close buttons * [components] Last changes made together with Victoria * [components] fix action title bug * [components] updates according to kris' review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.