[validation] Disable uniqueness check for fields in arrays #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have fields within an array that contain slugs, the uniqueness check doesn't currently work. In addition to not actually working, it raises a few interesting questions about what should be considered as unique. Unique within the array? Unique within all documents of the same type, within the array?
For now, I've disabled the uniqueness check and warned when this happens. In the future, we may be able to provide a better check that works either on array level or globally, but we need a better validation machine that batches requests and makes sure it doesn't fire too many checks at once.