Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Only alias react-dom in development #1436

Merged
merged 1 commit into from
Aug 13, 2019
Merged

[server] Only alias react-dom in development #1436

merged 1 commit into from
Aug 13, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Aug 12, 2019

I should have caught this in the code review: https://travis-ci.org/sanity-io/sanity/jobs/570811472

We should only alias react-dom in development. In production, we want to use the regular react-dom.

@rexxars rexxars requested a review from bjoerge August 12, 2019 13:24
bjoerge
bjoerge approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I misunderstood the docs for @hot-loader/react-dom, it said:

production bundle, exported by this package is identical to the original react-dom.production.min.js. It is safe to keep rewiring in production.

Thanks for noticing!

@bjoerge bjoerge merged commit add49d7 into next Aug 13, 2019
@bjoerge bjoerge deleted the hot-loader-fix branch August 13, 2019 07:51
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@rexxars @bjoerge
[server] Only alias react-dom in development (#1436)
55bb8c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexxars @bjoerge