Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fix potential crash when attempting to normalize module path #1635

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 27, 2019

Sometimes the hot module reloading cannot find a module in it's module map - when this happens the process-update script fails because it tries to split a string which is actually undefined. We only use this to display which modules have been updated, so it's non-critical that the path is correct.

This PR checks for this case and returns <unknown> should we not be passed a path name.

@rexxars rexxars requested a review from bjoerge November 27, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants