Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Reject template download if statusCode is not 2xx #1638

Merged
merged 1 commit into from
Nov 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ function getZip(url) {
return
}

if (res.statusCode > 299) {
const httpErr = ['HTTP', res.statusCode, res.statusMessage].filter(Boolean).join(' ')
reject(new Error(`${httpErr} trying to download ${url}`))
return
}

resolve(decompress(data))
})
})
Expand Down