-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove bundle slugs in favor of bundle id #7427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Aug 29, 2024 4:50 PM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
approved these changes
Aug 29, 2024
bjoerge
added a commit
that referenced
this pull request
Aug 30, 2024
bjoerge
added a commit
that referenced
this pull request
Aug 30, 2024
bjoerge
added a commit
that referenced
this pull request
Aug 30, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes from using a slugified release title as the release bundle id to instead use the
_id
of the release document.r
+ 8 random characters._id
of the release document, so for example the document with_id=foo
in the releaserA1NyH7Yo
will be assigned the_id=versions.rA1NyH7Yo.foo
Since the release id is used as a path segment, we always prepend the letter
r
to avoid it from starting with a number, and also make it apparent that it's a release bundle. The random release id generation is implemented in createReleaseId.tsNote: We want to use
_type: 'release'
for the release-metadata documents going forward, so I made that change as part of this PR (to avoid multiple passes of deleting existing test-data) - a follow up task should be to rename release specific components in accordance.What to review
Quite a big diff I'm afraid, but mostly trivial changes swapping from
bundle.slug
tobundle._id
.Testing
Existing tests should be enough. Some of the tests are updated to reflect the new bundle id scheme.
Notes for release
n/a