fix(core): update useReleaseHistory to fetch with the version documents #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobonamin
requested review from
ryanbonial
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pedrobonamin
requested review from
a team and
juice49
and removed request for
ryanbonial
|
No changes to documentation |
|
Component Testing Report Updated Sep 4, 2024 12:26 PM (UTC) ✅ All Tests Passed -- expand for details
|
RitaDias
reviewed
Sep 4, 2024
| @@ -21,14 +24,14 @@ export function useReleaseHistory(bundleDocumentsIds: string[]): { | |||
| const {dataset, token} = client.config() | |||
| const [history, setHistory] = useState<TransactionLogEventWithEffects[]>([]) | |||
| const queryParams = `tag=sanity.studio.tasks.history&effectFormat=mendoza&excludeContent=true&includeIdentifiedDocumentsOnly=true` | |||
|
|
|||
| const publishedIds = bundleDocumentsIds.map((id) => getPublishedId(id)).join(',') | |||
| const publishedIds = bundleDocumentsIds.map((id) => getVersionId(id, releaseId)).join(',') | |||
There was a problem hiding this comment.
I think we might need to rename the const to documentIds or maybe add a comment to clarify? Just bringing it up since we are technically bringing up a bunch of version ids (which are not publishedIds) 🤔
There was a problem hiding this comment.
I agree @RitaDias. Based on my understanding from glancing over the code, at least 🙂.
There was a problem hiding this comment.
TRUE missed that rename! will push the update and merge
juice49
approved these changes
Sep 4, 2024
RitaDias
approved these changes
Sep 4, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ts (#7463) * fix(core): update useReleaseHistory to fetch with the version documents * fix(core): rename publishedIds to versionIds in useReleaseHistory
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
…ts (#7463) * fix(core): update useReleaseHistory to fetch with the version documents * fix(core): rename publishedIds to versionIds in useReleaseHistory
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ts (#7463) * fix(core): update useReleaseHistory to fetch with the version documents * fix(core): rename publishedIds to versionIds in useReleaseHistory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
useReleaseHistoryhook was incorrectly constructing the ID of the documents it needs to fetch and construct the history.What to review
Testing
Notes for release