Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-studio): add asset types to structure navigation #7631

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Oct 18, 2024

Description

It is useful to see the image and file assets at times - this PR adds some structure entries for them to the test studio structure. Also removes an annoying warning about not specifying API version for one of the document lists.

What to review

Structure items shows up, works.

Testing

None

Notes for release

None

@rexxars rexxars requested a review from a team as a code owner October 18, 2024 14:55
@rexxars rexxars requested review from binoy14 and removed request for a team October 18, 2024 14:55
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:03pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:03pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:03pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:03pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 18, 2024 3:03pm
page-building-studio ⬜️ Skipped (Inspect) Oct 18, 2024 3:03pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Oct 18, 2024 3:03 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 54s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 18 Oct 2024 15:06:24 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.9 efps (63ms) 16.5 efps (61ms) -3ms (-4.0%)
article (body) 56.2 efps (18ms) 56.2 efps (18ms) +0ms (+0.0%)
article (string inside object) 18.7 efps (54ms) 18.3 efps (55ms) +1ms (+1.9%)
article (string inside array) 14.5 efps (69ms) 14.7 efps (68ms) -1ms (-1.4%)
recipe (name) 29.4 efps (34ms) 31.7 efps (32ms) -3ms (-7.4%)
recipe (description) 35.7 efps (28ms) 35.7 efps (28ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.4 efps (70ms) 14.6 efps (69ms) -1ms (-1.4%)
synthetic (string inside object) 15.5 efps (65ms) 15.4 efps (65ms) +1ms (+0.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 63ms 73ms 95ms 197ms 534ms 13.8s
article (body) 18ms 20ms 32ms 211ms 266ms 6.3s
article (string inside object) 54ms 56ms 63ms 178ms 207ms 8.4s
article (string inside array) 69ms 73ms 108ms 196ms 1005ms 9.9s
recipe (name) 34ms 36ms 55ms 84ms 7ms 10.6s
recipe (description) 28ms 30ms 33ms 63ms 0ms 5.8s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 70ms 73ms 81ms 565ms 1928ms 15.8s
synthetic (string inside object) 65ms 75ms 96ms 586ms 1743ms 10.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 64ms 79ms 128ms 422ms 14.1s
article (body) 18ms 21ms 84ms 194ms 307ms 5.9s
article (string inside object) 55ms 59ms 71ms 206ms 193ms 8.4s
article (string inside array) 68ms 75ms 86ms 282ms 897ms 9.7s
recipe (name) 32ms 35ms 64ms 88ms 3ms 10.0s
recipe (description) 28ms 30ms 46ms 117ms 1ms 6.1s
recipe (instructions) 6ms 8ms 8ms 9ms 0ms 3.2s
synthetic (title) 69ms 70ms 76ms 439ms 1536ms 14.8s
synthetic (string inside object) 65ms 69ms 82ms 678ms 1764ms 10.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@rexxars rexxars added this pull request to the merge queue Oct 21, 2024
Merged via the queue into next with commit f1f21fd Oct 21, 2024
66 checks passed
@rexxars rexxars deleted the chore/add-asset-structure-entries branch October 21, 2024 14:05
bjoerge added a commit that referenced this pull request Oct 23, 2024
* next:
  v3.62.0
  fix: warnings on React 19 (#7654)
  fix(deps): update dependency @sanity/ui to ^2.8.10 (#7652)
  fix(deps): update dependency @sanity/ui to ^2.8.10 (#7653)
  chore(deps): update dependency @sanity/visual-editing to v2.2.2 (#7651)
  fix(core): inherit readOnly state from ancestors in copyPaste function (#7643)
  fix(deps): update dependency @sanity/mutate to ^0.10.1 (#7650)
  fix(deps): Update dev-non-major (#7649)
  fix(deps): update dependency @sanity/presentation to v1.17.3 (#7648)
  fix(deps): update dependency @portabletext/editor to ^1.1.5 (#7638)
  fix(deps): update dependency @sanity/presentation to v1.17.2 (#7647)
  fix(deps): Update dev-non-major (#7646)
  fix(deps): update dependency @sanity/presentation to v1.17.1 (#7645)
  chore(deps): update dependency @sanity/preview-url-secret to v2 (#7641)
  fix(deps): update dependency @sanity/presentation to v1.17.0 (#7640)
  fix(deps): Update dev-non-major (#7639)
  chore(cli): update help copy for deploy command (#7624)
  chore(test-studio): add asset types to structure navigation (#7631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants