Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: making published perspective not a ReleaseDocument #7699

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:16am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:16am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:16am
page-building-studio ⬜️ Skipped (Inspect) Oct 30, 2024 6:16am
test-compiled-studio ⬜️ Skipped (Inspect) Oct 30, 2024 6:16am
test-next-studio ⬜️ Skipped (Inspect) Oct 30, 2024 6:16am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 30, 2024

⚡️ Editor Performance Report

Updated Wed, 30 Oct 2024 06:57:19 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.1 efps (62ms) 11.2 efps (89ms) +27ms (+43.5%) 🔴
article (body) 59.5 efps (17ms) 53.5 efps (19ms) +2ms (+11.3%)
article (string inside object) 17.5 efps (57ms) 12.2 efps (82ms) +25ms (+43.9%) 🔴
article (string inside array) 14.4 efps (70ms) 10.6 efps (94ms) +25ms (+35.3%) 🔴
recipe (name) 28.6 efps (35ms) 18.5 efps (54ms) +19ms (+54.3%) 🔴
recipe (description) 32.3 efps (31ms) 19.0 efps (53ms) +22ms (+69.4%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.4 efps (70ms) 5.7 efps (177ms) +107ms (+154.0%) 🔴
synthetic (string inside object) 14.7 efps (68ms) 5.9 efps (171ms) +103ms (+150.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 62ms 77ms 104ms 317ms 713ms 14.6s
article (body) 17ms 20ms 28ms 137ms 302ms 5.8s
article (string inside object) 57ms 61ms 75ms 315ms 507ms 8.9s
article (string inside array) 70ms 74ms 88ms 217ms 1109ms 9.7s
recipe (name) 35ms 38ms 77ms 109ms 6ms 9.5s
recipe (description) 31ms 32ms 38ms 138ms 6ms 6.4s
recipe (instructions) 6ms 9ms 9ms 10ms 0ms 3.2s
synthetic (title) 70ms 74ms 82ms 211ms 1548ms 15.4s
synthetic (string inside object) 68ms 72ms 89ms 188ms 1784ms 10.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 89ms 131ms 284ms 503ms 5661ms 20.8s
article (body) 19ms 23ms 59ms 279ms 645ms 7.4s
article (string inside object) 82ms 88ms 107ms 348ms 3943ms 13.4s
article (string inside array) 94ms 107ms 169ms 352ms 5436ms 15.9s
recipe (name) 54ms 67ms 208ms 231ms 2945ms 14.9s
recipe (description) 53ms 64ms 199ms 267ms 3290ms 12.0s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.5s
synthetic (title) 177ms 186ms 443ms 842ms 13067ms 30.9s
synthetic (string inside object) 171ms 192ms 462ms 1093ms 13925ms 26.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@vercel vercel bot temporarily deployed to Preview – test-compiled-studio October 30, 2024 06:16 Inactive
@vercel vercel bot temporarily deployed to Preview – page-building-studio October 30, 2024 06:16 Inactive
@vercel vercel bot temporarily deployed to Preview – test-next-studio October 30, 2024 06:16 Inactive
@jordanl17 jordanl17 marked this pull request as ready for review October 30, 2024 06:17
@jordanl17 jordanl17 requested a review from a team as a code owner October 30, 2024 06:17
@jordanl17 jordanl17 requested review from binoy14 and removed request for a team October 30, 2024 06:17
@jordanl17 jordanl17 merged commit d8bf21a into corel Oct 30, 2024
42 of 44 checks passed
@jordanl17 jordanl17 deleted the corel-published-perspective-not-release branch October 30, 2024 06:17
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Component Testing Report Updated Oct 30, 2024 6:45 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 16s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 8s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 52s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 59s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant