Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): update inputs 2 #7704

Merged
merged 9 commits into from
Oct 31, 2024
Merged

feat(sanity): update inputs 2 #7704

merged 9 commits into from
Oct 31, 2024

Conversation

RitaDias
Copy link
Contributor

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:18am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:18am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:18am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:18am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 7:18am

@RitaDias RitaDias changed the title Corel 175 2 feat(sanity): update inputs Oct 30, 2024
@RitaDias RitaDias changed the title feat(sanity): update inputs feat(sanity): update inputs 2 Oct 30, 2024
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Component Testing Report Updated Oct 31, 2024 7:15 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 8s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 50s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 51s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 58s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 30, 2024

⚡️ Editor Performance Report

Updated Thu, 31 Oct 2024 07:29:39 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.9 efps (63ms) 12.0 efps (83ms) +20ms (+31.7%) 🔴
article (body) 56.2 efps (18ms) 54.8 efps (18ms) +0ms (+2.5%)
article (string inside object) 17.9 efps (56ms) 12.7 efps (79ms) +23ms (+41.1%) 🔴
article (string inside array) 14.5 efps (69ms) 10.6 efps (94ms) +25ms (+36.2%) 🔴
recipe (name) 28.6 efps (35ms) 20.0 efps (50ms) +15ms (+42.9%) 🔴
recipe (description) 32.3 efps (31ms) 20.6 efps (49ms) +18ms (+56.5%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.9 efps (67ms) 5.8 efps (172ms) +105ms (+156.7%) 🔴
synthetic (string inside object) 14.5 efps (69ms) 6.1 efps (164ms) +95ms (+137.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 63ms 69ms 80ms 293ms 633ms 14.6s
article (body) 18ms 21ms 28ms 245ms 357ms 6.0s
article (string inside object) 56ms 58ms 67ms 183ms 453ms 8.9s
article (string inside array) 69ms 74ms 80ms 225ms 1075ms 9.5s
recipe (name) 35ms 39ms 59ms 78ms 21ms 8.8s
recipe (description) 31ms 33ms 47ms 95ms 0ms 6.3s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 67ms 69ms 77ms 457ms 1820ms 15.9s
synthetic (string inside object) 69ms 72ms 80ms 397ms 1656ms 10.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 83ms 97ms 288ms 500ms 4548ms 19.7s
article (body) 18ms 23ms 50ms 196ms 417ms 6.6s
article (string inside object) 79ms 86ms 264ms 383ms 4231ms 13.6s
article (string inside array) 94ms 102ms 273ms 437ms 5676ms 16.2s
recipe (name) 50ms 56ms 186ms 230ms 2363ms 13.4s
recipe (description) 49ms 54ms 71ms 100ms 2293ms 10.9s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.4s
synthetic (title) 172ms 188ms 203ms 1165ms 12011ms 30.1s
synthetic (string inside object) 164ms 180ms 277ms 1211ms 12758ms 25.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant