Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releases): supporting selecting a publish time on scheduled releases #7716

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

jordanl17
Copy link
Member

…ases

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:41pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:41pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:41pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:41pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:41pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 7:41pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Component Testing Report Updated Oct 31, 2024 7:40 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 50s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 59s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 31, 2024

⚡️ Editor Performance Report

Updated Thu, 31 Oct 2024 19:50:12 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.1 efps (59ms) 11.5 efps (87ms) +29ms (+48.7%) 🔴
article (body) 56.3 efps (18ms) 56.3 efps (18ms) +0ms (-/-%)
article (string inside object) 18.9 efps (53ms) 12.8 efps (78ms) +25ms (+47.2%) 🔴
article (string inside array) 16.3 efps (62ms) 10.6 efps (94ms) +33ms (+52.8%) 🔴
recipe (name) 30.3 efps (33ms) 20.0 efps (50ms) +17ms (+51.5%) 🔴
recipe (description) 33.3 efps (30ms) 21.3 efps (47ms) +17ms (+56.7%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.5 efps (69ms) 5.9 efps (169ms) +100ms (+144.9%) 🔴
synthetic (string inside object) 15.2 efps (66ms) 6.0 efps (166ms) +100ms (+150.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 59ms 65ms 105ms 326ms 651ms 14.1s
article (body) 18ms 20ms 25ms 100ms 461ms 6.3s
article (string inside object) 53ms 55ms 65ms 279ms 474ms 8.7s
article (string inside array) 62ms 65ms 85ms 240ms 672ms 9.0s
recipe (name) 33ms 36ms 70ms 122ms 11ms 9.6s
recipe (description) 30ms 32ms 33ms 57ms 9ms 6.0s
recipe (instructions) 6ms 8ms 9ms 22ms 0ms 3.3s
synthetic (title) 69ms 72ms 80ms 320ms 1367ms 15.9s
synthetic (string inside object) 66ms 73ms 85ms 172ms 1200ms 10.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 87ms 97ms 297ms 458ms 4624ms 20.2s
article (body) 18ms 21ms 37ms 310ms 609ms 6.6s
article (string inside object) 78ms 84ms 173ms 390ms 3967ms 13.2s
article (string inside array) 94ms 107ms 194ms 622ms 5074ms 15.1s
recipe (name) 50ms 58ms 70ms 172ms 2230ms 14.3s
recipe (description) 47ms 55ms 195ms 237ms 2113ms 10.7s
recipe (instructions) 6ms 8ms 11ms 187ms 208ms 4.2s
synthetic (title) 169ms 177ms 194ms 310ms 10554ms 28.3s
synthetic (string inside object) 166ms 181ms 202ms 843ms 11341ms 22.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant