Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove jest package from monorepo #7747

Merged
merged 2 commits into from
Nov 5, 2024
Merged

test: remove jest package from monorepo #7747

merged 2 commits into from
Nov 5, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Nov 5, 2024

Description

What to review

Testing

Notes for release

@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:15pm
performance-studio ✅ Ready (Inspect) Visit Preview Nov 5, 2024 4:15pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:15pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 4:15pm

@binoy14 binoy14 mentioned this pull request Nov 5, 2024
Merged
@binoy14 Graphite App
Copy link
Contributor Author

binoy14 commented Nov 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite Graphite

@binoy14 binoy14 mentioned this pull request Nov 5, 2024
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Nov 5, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Component Testing Report Updated Nov 5, 2024 4:12 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 32s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Tue, 05 Nov 2024 16:14:43 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 17.2 efps (58ms) 17.2 efps (58ms) +0ms (-/-%) ✅
article (body) 58.0 efps (17ms) 59.7 efps (17ms) -1ms (-2.9%) ✅
article (string inside object) 19.2 efps (52ms) 18.2 efps (55ms) +3ms (+5.8%) ✅
article (string inside array) 16.4 efps (61ms) 15.6 efps (64ms) +3ms (+4.9%) ✅
recipe (name) 28.6 efps (35ms) 29.4 efps (34ms) -1ms (-2.9%) ✅
recipe (description) 32.8 efps (31ms) 32.3 efps (31ms) +1ms (+1.6%) ✅
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) -0ms (-/-%) ✅
synthetic (title) 14.2 efps (71ms) 14.7 efps (68ms) -3ms (-3.5%) ✅
synthetic (string inside object) 14.5 efps (69ms) 14.6 efps (69ms) -1ms (-0.7%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 64ms 77ms 221ms 532ms 13.2s
article (body) 17ms 23ms 42ms 191ms 295ms 5.8s
article (string inside object) 52ms 55ms 61ms 200ms 246ms 8.3s
article (string inside array) 61ms 66ms 75ms 198ms 700ms 9.1s
recipe (name) 35ms 39ms 63ms 75ms 24ms 9.4s
recipe (description) 31ms 32ms 36ms 59ms 2ms 6.0s
recipe (instructions) 7ms 9ms 10ms 17ms 7ms 3.4s
synthetic (title) 71ms 75ms 79ms 353ms 1657ms 14.8s
synthetic (string inside object) 69ms 74ms 83ms 556ms 2069ms 10.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 62ms 74ms 151ms 414ms 13.1s
article (body) 17ms 19ms 22ms 160ms 294ms 5.8s
article (string inside object) 55ms 57ms 64ms 211ms 252ms 8.3s
article (string inside array) 64ms 67ms 78ms 216ms 722ms 9.1s
recipe (name) 34ms 38ms 66ms 90ms 0ms 10.7s
recipe (description) 31ms 33ms 38ms 102ms 0ms 6.1s
recipe (instructions) 7ms 8ms 10ms 15ms 0ms 3.4s
synthetic (title) 68ms 71ms 86ms 338ms 1500ms 15.1s
synthetic (string inside object) 69ms 75ms 92ms 328ms 1659ms 9.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Base automatically changed from 11-05-test_perf_migrate_perf_runner_tests_to_vitest to sdk-29 November 5, 2024 16:14
@binoy14 binoy14 merged commit e436287 into sdk-29 Nov 5, 2024
56 of 58 checks passed
@binoy14 binoy14 deleted the 11-05-test_remove_jest_package_from_monorepo branch November 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@binoy14