Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): remove perspective state from router #7749

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

We are storing the same state in the usePerspective hook and in the router, this PR removes the one from the router.

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:23am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:23am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:23am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:23am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 10:23am

Copy link
Contributor

github-actions bot commented Nov 5, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 5, 2024

⚡️ Editor Performance Report

Updated Tue, 05 Nov 2024 10:23:09 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.2 efps (58ms) 11.8 efps (85ms) +27ms (+46.6%) 🔴
article (body) 56.0 efps (18ms) 48.4 efps (21ms) +3ms (+15.7%)
article (string inside object) 18.9 efps (53ms) 12.7 efps (79ms) +26ms (+49.1%) 🔴
article (string inside array) 15.9 efps (63ms) 10.8 efps (93ms) +30ms (+46.8%) 🔴
recipe (name) 27.0 efps (37ms) 17.4 efps (58ms) +21ms (+55.4%) 🔴
recipe (description) 31.3 efps (32ms) 20.2 efps (50ms) +18ms (+54.7%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +0ms (-/-%)
synthetic (title) 14.5 efps (69ms) 5.6 efps (178ms) +109ms (+158.0%) 🔴
synthetic (string inside object) 15.0 efps (67ms) 6.0 efps (166ms) +100ms (+149.6%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 65ms 78ms 210ms 370ms 13.1s
article (body) 18ms 23ms 30ms 211ms 314ms 6.0s
article (string inside object) 53ms 55ms 62ms 194ms 266ms 8.2s
article (string inside array) 63ms 69ms 80ms 203ms 684ms 9.0s
recipe (name) 37ms 41ms 60ms 86ms 30ms 8.8s
recipe (description) 32ms 34ms 50ms 194ms 4ms 6.7s
recipe (instructions) 7ms 9ms 10ms 11ms 6ms 3.4s
synthetic (title) 69ms 73ms 81ms 153ms 1513ms 15.8s
synthetic (string inside object) 67ms 69ms 92ms 510ms 1753ms 10.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 85ms 90ms 122ms 317ms 3949ms 19.5s
article (body) 21ms 44ms 140ms 377ms 1539ms 8.7s
article (string inside object) 79ms 92ms 258ms 292ms 3683ms 13.0s
article (string inside array) 93ms 101ms 250ms 420ms 5187ms 15.5s
recipe (name) 58ms 84ms 220ms 269ms 3449ms 15.8s
recipe (description) 50ms 63ms 199ms 278ms 2733ms 11.1s
recipe (instructions) 7ms 9ms 10ms 33ms 152ms 4.0s
synthetic (title) 178ms 194ms 278ms 670ms 12618ms 30.2s
synthetic (string inside object) 166ms 176ms 446ms 1003ms 12327ms 24.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Component Testing Report Updated Nov 5, 2024 10:20 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 8s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 48s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 56s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants