Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sanity): add guardrails to date and title when creating releases #7761

Closed
wants to merge 2 commits into from

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Nov 6, 2024

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:05am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:05am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:05am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:05am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 6, 2024 9:05am

Copy link
Contributor

github-actions bot commented Nov 6, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 6, 2024

⚡️ Editor Performance Report

Updated Wed, 06 Nov 2024 09:06:03 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.2 efps (58ms) 11.6 efps (87ms) +29ms (+49.1%) 🔴
article (body) 56.5 efps (18ms) 53.2 efps (19ms) +1ms (+6.2%)
article (string inside object) 18.3 efps (55ms) 13.2 efps (76ms) +22ms (+39.4%) 🔴
article (string inside array) 15.4 efps (65ms) 10.6 efps (94ms) +29ms (+44.6%) 🔴
recipe (name) 29.9 efps (34ms) 19.0 efps (53ms) +19ms (+56.7%) 🔴
recipe (description) 34.5 efps (29ms) 20.4 efps (49ms) +20ms (+69.0%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 13.8 efps (73ms) 5.6 efps (180ms) +108ms (+148.3%) 🔴
synthetic (string inside object) 14.3 efps (70ms) 5.5 efps (182ms) +112ms (+160.0%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 61ms 74ms 216ms 388ms 14.0s
article (body) 18ms 20ms 41ms 189ms 266ms 5.9s
article (string inside object) 55ms 58ms 62ms 111ms 256ms 8.7s
article (string inside array) 65ms 74ms 97ms 303ms 1061ms 9.7s
recipe (name) 34ms 36ms 40ms 87ms 15ms 9.6s
recipe (description) 29ms 31ms 33ms 55ms 0ms 6.0s
recipe (instructions) 6ms 8ms 9ms 9ms 0ms 3.3s
synthetic (title) 73ms 75ms 101ms 466ms 1796ms 15.9s
synthetic (string inside object) 70ms 73ms 82ms 736ms 2073ms 10.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 87ms 95ms 160ms 384ms 3736ms 19.7s
article (body) 19ms 27ms 53ms 304ms 854ms 8.5s
article (string inside object) 76ms 85ms 266ms 481ms 3313ms 12.7s
article (string inside array) 94ms 103ms 265ms 451ms 4670ms 15.0s
recipe (name) 53ms 59ms 88ms 266ms 3019ms 14.6s
recipe (description) 49ms 56ms 78ms 212ms 2369ms 10.5s
recipe (instructions) 6ms 8ms 9ms 35ms 23ms 4.3s
synthetic (title) 180ms 198ms 439ms 1094ms 13580ms 31.7s
synthetic (string inside object) 182ms 200ms 482ms 942ms 14305ms 27.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Component Testing Report Updated Nov 6, 2024 9:14 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 51s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 57s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RitaDias RitaDias closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant