Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): rename dialogs #7774

Merged
merged 1 commit into from
Nov 7, 2024
Merged

refactor(core): rename dialogs #7774

merged 1 commit into from
Nov 7, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Nov 7, 2024

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:47am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:47am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:47am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:47am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 7, 2024 10:47am

Copy link
Contributor

github-actions bot commented Nov 7, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Component Testing Report Updated Nov 7, 2024 10:44 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 51s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 58s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚡️ Editor Performance Report

Updated Thu, 07 Nov 2024 10:47:13 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.5 efps (54ms) 13.0 efps (77ms) +23ms (+42.6%) 🔴
article (body) 53.8 efps (19ms) 59.9 efps (17ms) -2ms (-10.2%)
article (string inside object) 17.5 efps (57ms) 13.6 efps (74ms) +17ms (+28.9%) 🔴
article (string inside array) 15.6 efps (64ms) 11.1 efps (90ms) +26ms (+40.6%) 🔴
recipe (name) 32.3 efps (31ms) 20.4 efps (49ms) +18ms (+58.1%) 🔴
recipe (description) 36.4 efps (28ms) 21.5 efps (47ms) +19ms (+69.1%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.5 efps (69ms) 5.7 efps (174ms) +105ms (+152.2%) 🔴
synthetic (string inside object) 14.4 efps (70ms) 6.2 efps (161ms) +92ms (+131.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 54ms 56ms 69ms 234ms 376ms 15.0s
article (body) 19ms 20ms 35ms 187ms 296ms 5.9s
article (string inside object) 57ms 62ms 70ms 206ms 272ms 8.7s
article (string inside array) 64ms 67ms 74ms 113ms 743ms 9.1s
recipe (name) 31ms 34ms 37ms 73ms 0ms 8.5s
recipe (description) 28ms 29ms 32ms 49ms 0ms 5.7s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 69ms 71ms 79ms 164ms 1385ms 15.1s
synthetic (string inside object) 70ms 73ms 145ms 350ms 1599ms 10.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 77ms 81ms 100ms 288ms 2697ms 16.3s
article (body) 17ms 20ms 46ms 181ms 523ms 6.2s
article (string inside object) 74ms 78ms 91ms 287ms 2588ms 11.1s
article (string inside array) 90ms 93ms 100ms 174ms 3166ms 12.0s
recipe (name) 49ms 52ms 56ms 99ms 851ms 11.0s
recipe (description) 47ms 48ms 59ms 159ms 746ms 8.3s
recipe (instructions) 6ms 8ms 9ms 23ms 0ms 3.3s
synthetic (title) 174ms 190ms 301ms 696ms 9974ms 26.9s
synthetic (string inside object) 161ms 165ms 175ms 1081ms 9192ms 19.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias merged commit 264d4c9 into corel Nov 7, 2024
59 checks passed
@RitaDias RitaDias deleted the rename-dialogs branch November 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant