Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sanity): fix date formating, add locked chips and locked document on scheduled releases #7775

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Nov 7, 2024

Description

updated tooltip contents
update formatting for document header
add locked icon to chips on the document header
add banner when the release is scheduled / locked
make document readOnly when release is locked

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:46pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:46pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:46pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:46pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:46pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 2:46pm

@RitaDias RitaDias changed the title Corel fix date displays refactor(sanity): fix date formating, add locked chips and locked document on scheduled releases Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Component Testing Report Updated Nov 7, 2024 2:42 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 50s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 58s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚡️ Editor Performance Report

Updated Thu, 07 Nov 2024 14:44:12 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.9 efps (56ms) 12.2 efps (82ms) +26ms (+46.4%) 🔴
article (body) 56.5 efps (18ms) 59.5 efps (17ms) -1ms (-5.1%)
article (string inside object) 19.0 efps (53ms) 13.4 efps (75ms) +22ms (+41.9%) 🔴
article (string inside array) 16.1 efps (62ms) 11.0 efps (91ms) +29ms (+46.8%) 🔴
recipe (name) 28.6 efps (35ms) 19.2 efps (52ms) +17ms (+48.6%) 🔴
recipe (description) 33.3 efps (30ms) 19.6 efps (51ms) +21ms (+70.0%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 14.5 efps (69ms) 5.6 efps (177ms) +108ms (+156.5%) 🔴
synthetic (string inside object) 14.1 efps (71ms) 6.1 efps (165ms) +94ms (+132.4%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 56ms 62ms 71ms 212ms 370ms 12.7s
article (body) 18ms 20ms 30ms 104ms 145ms 5.7s
article (string inside object) 53ms 55ms 70ms 224ms 397ms 8.4s
article (string inside array) 62ms 67ms 79ms 282ms 799ms 9.4s
recipe (name) 35ms 39ms 67ms 81ms 0ms 9.6s
recipe (description) 30ms 32ms 37ms 64ms 3ms 6.0s
recipe (instructions) 6ms 8ms 9ms 22ms 0ms 3.3s
synthetic (title) 69ms 72ms 82ms 375ms 1531ms 16.2s
synthetic (string inside object) 71ms 74ms 85ms 422ms 1716ms 10.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 82ms 89ms 170ms 381ms 3158ms 16.8s
article (body) 17ms 20ms 32ms 277ms 478ms 5.9s
article (string inside object) 75ms 77ms 83ms 447ms 2825ms 11.5s
article (string inside array) 91ms 96ms 117ms 366ms 3571ms 12.8s
recipe (name) 52ms 54ms 57ms 84ms 1029ms 11.3s
recipe (description) 51ms 53ms 56ms 95ms 906ms 8.4s
recipe (instructions) 7ms 10ms 11ms 24ms 34ms 3.6s
synthetic (title) 177ms 184ms 200ms 541ms 9363ms 26.4s
synthetic (string inside object) 165ms 174ms 193ms 890ms 9553ms 20.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant