Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Studio teams in CODEOWNERS #7780

Open
wants to merge 1 commit into from
Open

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Nov 7, 2024

This commit changes all Studio teams in CODEOWNERS to @sanity-io/studio, which is necessary because the @sanity-io/studio-dx and @sanity-io/studio-ex teams have been removed.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:13pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:13pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:13pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:13pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 5:13pm

Copy link
Contributor

github-actions bot commented Nov 7, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Component Testing Report Updated Nov 7, 2024 5:16 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 33s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 37s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚡️ Editor Performance Report

Updated Thu, 07 Nov 2024 17:19:44 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.6 efps (64ms) 16.4 efps (61ms) -3ms (-4.7%)
article (body) 53.5 efps (19ms) 53.5 efps (19ms) +0ms (-/-%)
article (string inside object) 18.0 efps (56ms) 16.7 efps (60ms) +5ms (+8.1%)
article (string inside array) 14.7 efps (68ms) 14.5 efps (69ms) +1ms (+1.5%)
recipe (name) 30.3 efps (33ms) 31.3 efps (32ms) -1ms (-3.0%)
recipe (description) 35.1 efps (29ms) 35.7 efps (28ms) -1ms (-1.8%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.7 efps (68ms) 14.9 efps (67ms) -1ms (-1.5%)
synthetic (string inside object) 15.6 efps (64ms) 15.6 efps (64ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 64ms 71ms 80ms 331ms 781ms 14.5s
article (body) 19ms 22ms 29ms 163ms 324ms 6.2s
article (string inside object) 56ms 58ms 64ms 115ms 348ms 8.4s
article (string inside array) 68ms 72ms 85ms 332ms 1010ms 9.7s
recipe (name) 33ms 36ms 59ms 88ms 28ms 8.6s
recipe (description) 29ms 30ms 32ms 76ms 22ms 5.8s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 68ms 72ms 79ms 334ms 1402ms 14.9s
synthetic (string inside object) 64ms 68ms 78ms 328ms 1151ms 10.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 70ms 94ms 145ms 520ms 13.6s
article (body) 19ms 21ms 58ms 199ms 303ms 6.2s
article (string inside object) 60ms 64ms 75ms 309ms 505ms 9.2s
article (string inside array) 69ms 73ms 83ms 224ms 1028ms 9.7s
recipe (name) 32ms 35ms 60ms 72ms 0ms 8.6s
recipe (description) 28ms 30ms 32ms 47ms 0ms 5.7s
recipe (instructions) 6ms 8ms 8ms 10ms 0ms 3.2s
synthetic (title) 67ms 76ms 104ms 234ms 1553ms 15.1s
synthetic (string inside object) 64ms 68ms 74ms 345ms 838ms 9.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

This commit changes all Studio teams in CODEOWNERS to
`@sanity-io/studio`, which is necessary because the
`@sanity-io/studio-dx` and `@sanity-io/studio-ex` teams have been
removed.
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@juice49 juice49 added this pull request to the merge queue Nov 7, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants