Configure Sentry_SDK #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-rosenzweig
force-pushed
the
feature/sentry_sdk
branch
from
66998ed
to
339dcf3
Compare
The sentry raven library is long deprecated. The python sentry SDK replaces this library. To get the same behaviour as with raven (only enable the logging with selected loggers via the Handlers), one has to initialise the SDK but manually configure the Logging integration and set the default levels to None. Avoiding the sentry configuration in each SAPCC upstream based project (e.g. Neutron or Nova) and furthermore in each driver, this has is part of the loci build process. During the build a .pth and .py file will be placed in the site_package path. Within this path, an executable line in a .pth file is run at every Python startup. In our case, a script configuring sentry if the env variable SENTRY_USE_SDK is set. As requirements sentry-sdk must be installed. Co-authored-by: Florian Streibelt <[email protected]>
sven-rosenzweig
force-pushed
the
feature/sentry_sdk
branch
from
339dcf3
to
5074cea
Compare
|
I got some input from Seba yesterday, I think two things would make sense to add to the
This would prevent sentry getting enabled with every python process on the target which could otherwise send random logs to sentry, or interfere with debugging maybe. We however need to check if there are some "hidden" At the same time we could easily modify the list without building a new image, allowing us to add or remove scripts. That should come in handy when other services like nova want to test that approach. update: added as extra commit. |
Moved the ssentry.py to a file in a subdirectory, so it can be editied in an editor using syntax highlighting, formatting and autopep
allow filtering based on argv[0] to enable only for specific commands
changing the prefix of the variables to clearly distinguish between the namespace sentry is using and our own variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Sentry_SDK
The sentry raven library is long deprecated. The python sentry SDK replaces this library.
To get the same behaviour as with raven (only enable the logging with selected loggers via the Handlers), one has to initialise the SDK but manually configure the Logging integration and set the default levels to None.
Avoiding the sentry configuration in each SAPCC upstream based project (e.g. Neutron or Nova) and furthermore
in each driver, this has is part of the loci build process. During the build a .pth and .py file will be placed in the
site_package path. Within this path, an executable line in a .pth file is run at every Python startup.
In our case, a script configuring sentry if the env variable SENTRY_USE_SDK is
set. As requirements sentry-sdk must be installed.