-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Full screen option is not working... #241
Comments
Is it crashing or just not switching to fullscreen ? |
No it doesn't crash the application but it doesn't switch to full screen.. thanks for the quick reply |
Can you describe more on what exactly happens on switching to fullscreen mode? Also are you wrapping your player with YoutubePlayerBuilder ? |
yup i wrapped the youtube player inside youtube player builder and i even used your example code and it gave me the same error when i click on the full screen button, it fills out the screen with black for a fraction of second and then gets to its original portrait mode and the youtube player pauses |
After the update to v7, fullscreen doesn't work anymore. I wrapped the component in YoutubePlayerBuilder but it doesn't help. This is from the error-log:
|
@AshutoshPatole are you playing the video on a Dialog? Because that exactly happened to me when I tried from Dialog. After I switched to a dedicated layout for playing videos it worked just fine. Here is my code: `import 'package:flutter/material.dart'; class VideoView extends StatelessWidget { |
@vipinnegi90 no I'm not using a dialog to show the youtube and i tried your code too but it didn't worked and threw the same errors. is there anything with my code? but id did worked perfectly before updating to v7.x.x anyway I'm pasting a detailed log text to clear this issue. Edit 1: I just noticed that this error has nothing to do with my code. I created a new flutter project and added just flutter_youtube_player dependency and copied the code provided in examples just to make sure that it works but again it threw the same error. I even tried this in 2 different phones. honor 9i => android 8.0 @sarbagyastha please fix this issue and ping me if you need any more information from me.
|
@AshutoshPatole Could you please test with these apks ? |
@sarbagyastha yup it works perfectly but why didn't this worked when i copied the same code and tried to run in debug mode? |
Please provide a reproducible example so that i can test. Could't see anything suspicious in the log. |
@AshutoshPatole What is the flutter version you're compiling with? |
@vipinnegi90 flutter1.17.2 |
@AshutoshPatole I believe that's a typo for v1.17.1. Upgrade to v1.17.2 and try. |
updated Logs:
@vipinnegi90 even after upgrading to 1.17.2 and dart 2.8.3 the problem persists. The Global keys are in separate files
|
@AshutoshPatole did the issue fix for you? |
Why was this issue closed? I still have this problem #241 (comment) it seems that there is |
@vipinnegi90 yup the issue is fixed. @rafaelmaeuer for me using stack with youtube_player caused this issue. |
@AshutoshPatole did they fix the stack issue? or is that just a limitation now of using this plugin? |
This issue should not be closed even the sample with the YoutubePlayerBuilder will not go fullscreen. It just blips the player black and stays the same size |
for me the issue persists, although I am not using the player in a stack |
@emmett-deen It was the exact problem with me too. But the sample code worked just fine when implemented in new project(just the sample code). So i changed the entry point of the app in edit: i forgot to tell you that it is working as expected now |
@AshutoshPatole, I am also facing the same problem. Not sure how to fix it. I have tried adding the example code many times. |
I'm reopening this issue. Since many people are facing the same problem |
I think the issue is regarding the device's aspect ratio. It persists only when the aspect ratio is longer than 16:9. For example, I have no issue when I use Redmi 3S (16:9 ratio). But once I use Galaxy A50 (19.5:9 ratio), it just closes the full screen mode. |
And I have no issue when I use Galaxy S8. But once I use PIXEL 3, it just closes the full screen mode. :/ |
Same for me; The portrait player blinks black for a split second and then remains at the same size, nothing happens. |
Same problem here. It works only when the player is on a page with no other widgets. |
I am also facing the same problem. |
|
Same issue, the player tries to go fullscreen, but the player is larger then my actual screen: PlatformViewsController(16046): Creating a virtual display of size: [2201, 1080] may result in problems(flutter/flutter#2897 is larger than the device screen size: [2075, 1080]. EDIT: |
ME to |
Today I replaced this lib with youtube_plyr_iframe. Its a fork of youtube_player_iframe that is maintained, up to date and has some major issue fixed. The replacement is quite easy and it just works, including fullscreen from a widget-stack. |
@sarbagyastha I guess you should definitely look into this issue. I see many issues somewhat similar to this one. |
Any update?. |
Same issue, the video always fills the screen no matter what aspect ratio you give it. Wrapping it in SizedBox doesn't help either. |
@OverRide void portraitModeOnly() { void landscapeModeOnly() { @OverRide This workaround works perfectly. |
|
I implemented this into one of my application and the full screen didn't worked.
I even tried the example snippet provided in example/lib/main.dart but same log happened
This is the log
I/PressGestureDetector( 5303): ORIENTATION_LANDSCAPE
W/libEGL ( 5303): EGLNativeWindowType 0x7204703010 disconnect failed
D/mali_winsys( 5303): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
W/PlatformViewsController( 5303): Creating a virtual display of size: [2040, 1080] may result in problems(flutter/flutter#2897 is larger than the device screen size: [1080, 2040].
Device:
Honor 9i
Android 8.0
The text was updated successfully, but these errors were encountered: