Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected nmea sentence crashing the kbox #38

Closed
lfrancois opened this issue Jul 17, 2017 · 5 comments
Closed

unexpected nmea sentence crashing the kbox #38

lfrancois opened this issue Jul 17, 2017 · 5 comments
Labels

Comments

@lfrancois
Copy link

It seems one of my NMEA 2000 device crashes the kbox. I am going to try to isolate the device to provide you more information.

Any idea how to troubleshoot it? I am running the development branch right now.

Here are the logs from the serial console.

WD main.cpp:90 Still running ... 0 connected clients - 36560 heap - IP: 0.0.0.0
WD main.cpp:90 Still running ... 0 connected clients - 36560 heap - IP: 0.0.0.0
D NMEA2000Service.cpp:92 Sending message on n2k bus - pgn=127508 prio=6 src=22 dst=255 len=8 result=success
D NMEA2000Service.cpp:95 TX: $PCDIN,01F214,00000000,16,000000FF7FFFFF01*57
D NMEA2000Service.cpp:92 Sending message on n2k bus - pgn=127508 prio=6 src=22 dst=255 len=8 result=success
D NMEA2000Service.cpp:95 TX: $PCDIN,01F214,00000000,16,010100FF7FFFFF01*57
D NMEA2000Service.cpp:92 Sending message on n2k bus - pgn=127508 prio=6 src=22 dst=255 len=8 result=success
D NMEA2000Service.cpp:95 TX: $PCDIN,01F214,00000000,16,FF0000FF7FFFFF01*57
D NMEA2000Service.cpp:92 Sending message on n2k bus - pgn=127508 prio=6 src=22 dst=255 len=8 result=success
D NMEA2000Service.cpp:95 TX: $PCDIN,01F214,00000000,16,FF4505FF7FFFFF01*53
D NMEA2000Service.cpp:37 Received N2K Message with pgn: 60928
@lfrancois lfrancois changed the title nmea sentence crashing the kbox unexpected nmea sentence crashing the kbox Jul 17, 2017
@lfrancois
Copy link
Author

lfrancois commented Jul 17, 2017

It seems not related to the PGN above. Same issue with a different PGN.

D NMEA2000Service.cpp:37 Received N2K Message with pgn: 127505

As soon as this sentence happens the kbox dies and the select button becomes unresponsive.

@lfrancois
Copy link
Author

After a quick troubleshooting session, it seems two of my NMEA2000 devices are causing the problem:

  • Airmar P79
  • NAVICO TEMPERATURE SENSOR NMEA 2000

@lfrancois
Copy link
Author

The issue looks to come from the SDCard logging. As soon as I comment it, it works as expected.

ludo@idefix:~/repos/kbox-firmware % git diff                                                                                            15:10 #6253
diff --git a/src/host/main.cpp b/src/host/main.cpp
index d59e5e5..1b11cb3 100644
--- a/src/host/main.cpp
+++ b/src/host/main.cpp
@@ -84,7 +84,7 @@ void setup() {
   SDCardTask *sdcardTask = new SDCardTask();
   reader1->connectTo(*sdcardTask);
   reader2->connectTo(*sdcardTask);
-  n2kService->connectTo(*sdcardTask);
+  //n2kService->connectTo(*sdcardTask);
 
 
   // Add all the tasks
ludo@idefix:~/repos/kbox-firmware %```

sarfata pushed a commit that referenced this issue Jul 26, 2017
@sarfata sarfata added the bug label Sep 1, 2017
sarfata added a commit that referenced this issue Dec 10, 2017
47e7887 Changed default NMEA2000 variable to reference
68c7f7d Added PGN 127501 as known message
8ec61a9 Added Binary status report (PGN 127501) handling.
e05b5e9 Merge pull request #47 from thomasonw/master
9dab97a MBED edit
3c267ed Merge pull request #45 from thomasonw/master
8d0944f Added MBED auto-select
e8a9af6 Merge pull request #1 from ttlappalainen/master
4cf87d1 Merge branch 'master' of https://github.com/ttlappalainen/NMEA2000
ec0ac18 Merge pull request #44 from denravonska/pgn-additions
4b9f91f Fix double/udouble inconsistencies in PGN 129539.
8f422e2 Debug mode check for DeviceReady and ParseMessages
af23e8a Merge pull request #42 from thomasonw/master
ad165b5 Updated RPi guide
2141a05 Merge remote-tracking branch 'refs/remotes/ttlappalainen/master'
c7c7351 Docs for ATmegaxxM1 and RPi
6445531 Merge pull request #41 from thomasonw/master
82726d0 Added socketCAN to auto-selecction
af73628 Merge remote-tracking branch 'refs/remotes/ttlappalainen/master'
9209a7c Add parser for PGN 129284 (Navigation Info).
f60a3cb Add missing ParseN2kPGN129283.
9c8661c Merge branch 'gnss-support' of https://github.com/denravonska/NMEA2000 into gnss-support
a481b5e Add support for PGN 129539, GNSS DOP data.
ea71460 Added Heading parsing
6a15824 mbed compiler erro fixes
00c4df6 Merge remote-tracking branch 'refs/remotes/ttlappalainen/master'
3f215a1 Add support for PGN 129539, GNSS DOP data.
9a689c7 Fixed Heading PGN 127250 parsing
f51b8ed Added Teensy 3.5 and 3.6 support
025c395 Handle for PGN 65240 "Commanded address"
fee8d97 Copyright changes
ea94d1a Merge pull request #38 from denravonska/endian-and-alignment
a214584 Add comment about possible improvements in Get/SetBuf.
fe10b58 Document and some example fixes to match changes
6c457a9 Replace pointer casting with memcpy to avoid unaligned access, and add endian support.
8512745 Added support for PGN 126464L
5d0e058 Fixes to avoid compiler warnings
5a3e672 Portability fix and Readme update
5df071e Merge pull request #35 from denravonska/portability-fixes
e6509bb Move additional strings to flash.
1e56216 Add round() implementation for non-Arduino targets.
f2ff8ee Switch the way constant strings are handled.
2728972 Fix incorrect delay signature.
7cb08f0 Add println for flash stored strings and convert F() calls to CSTR().
7c754d6 Remove Serial object as it should be set by the application.
17c5966 Stray away from itoa as it's not available on all compilers.
97a80e8 Remove stray error.
5fd9923 Merge branch 'portability-fixes' of github.com:denravonska/NMEA2000 into portability-fixes
bd6b521 Fix N2kStream for AVR targets that aren't Arduinos.
c5f148a Fix N2kStream for AVR targets that aren't Arduinos.
6cf0e29 Fix for constant string storage on Arduinos.
90b2861 Merge branch 'portability-fixes' of github.com:denravonska/NMEA2000 into portability-fixes
75a441e Switch to using N2kStream and the constant data macros.
4963adf Add N2kStream interface for reading- and writing serial data. On Arduino this defaults to Stream.
c667544 Add header for platform abstraction.
4f91fbf Add missing header for memcpy.
29faf2d Replace byte with uint8_t.
41bc6d7 Add N2kStream interface for reading- and writing serial data. On Arduino this defaults to Stream.
9140aa9 Add header for platform abstraction.
69053d5 Add missing header for memcpy.
6c191b4 Replace byte with uint8_t.
2afabed Replace Arduino binary definitions with BIT(n) macro which uses bit shifts.
7af7236 Add missing headers.
74e3a86 Remove the dependency to Serial. The sub class can assign this pointer when needed.
b7cbcf6 License change to MIT
c708654 Merge pull request #34 from denravonska/message-setter-bugfix
7f4a82b Fix an issue where setting single- and multi frame messages always reverted back to default messages.
1889ab9 Merge pull request #30 from KimBP/master
3560f1c Merge pull request #29 from adwuk/master
c5f3d76 added support for PGN 127258 - magnetic variation
3d06610 N2kMessages: Added parsing of PGN129025 (PositionRapid)
2905054 N2kCANMsg: Proper C++ style initialization of class members
1bce0c5 N2kMessages: Fix COG and SOG parsing in PGN129026
dd5fca3 N2kMessages: msToKnots() added
5d93a44 Merge pull request #26 from adwuk/master
f66c408 Added parsing of PGN 130311
9672b37 Merge pull request #3 from ttlappalainen/master
7d568f8 Merge pull request #24 from sarfata/patch-1
65f36bd Fix typo in documentation for SetN2kSystemTime

git-subtree-dir: lib/NMEA2000
git-subtree-split: 47e7887
@sarfata
Copy link
Owner

sarfata commented Jun 14, 2018

@lfrancois did you ever see this again? can we close this now?

@lfrancois
Copy link
Author

Since the new kbox, new firmware, new sd card, everything works fine! :)

113Bom pushed a commit to 113Bom/kbox-firmware that referenced this issue Apr 9, 2022
f51b8ed Added Teensy 3.5 and 3.6 support
025c395 Handle for PGN 65240 "Commanded address"
fee8d97 Copyright changes
ea94d1a Merge pull request sarfata#38 from denravonska/endian-and-alignment
a214584 Add comment about possible improvements in Get/SetBuf.
fe10b58 Document and some example fixes to match changes
6c457a9 Replace pointer casting with memcpy to avoid unaligned access, and add endian support.
8512745 Added support for PGN 126464L
5d0e058 Fixes to avoid compiler warnings
5a3e672 Portability fix and Readme update
5df071e Merge pull request sarfata#35 from denravonska/portability-fixes
e6509bb Move additional strings to flash.
1e56216 Add round() implementation for non-Arduino targets.
f2ff8ee Switch the way constant strings are handled.
2728972 Fix incorrect delay signature.
7cb08f0 Add println for flash stored strings and convert F() calls to CSTR().
7c754d6 Remove Serial object as it should be set by the application.
17c5966 Stray away from itoa as it's not available on all compilers.
97a80e8 Remove stray error.
5fd9923 Merge branch 'portability-fixes' of github.com:denravonska/NMEA2000 into portability-fixes
bd6b521 Fix N2kStream for AVR targets that aren't Arduinos.
c5f148a Fix N2kStream for AVR targets that aren't Arduinos.
6cf0e29 Fix for constant string storage on Arduinos.
90b2861 Merge branch 'portability-fixes' of github.com:denravonska/NMEA2000 into portability-fixes
75a441e Switch to using N2kStream and the constant data macros.
4963adf Add N2kStream interface for reading- and writing serial data. On Arduino this defaults to Stream.
c667544 Add header for platform abstraction.
4f91fbf Add missing header for memcpy.
29faf2d Replace byte with uint8_t.
41bc6d7 Add N2kStream interface for reading- and writing serial data. On Arduino this defaults to Stream.
9140aa9 Add header for platform abstraction.
69053d5 Add missing header for memcpy.
6c191b4 Replace byte with uint8_t.
2afabed Replace Arduino binary definitions with BIT(n) macro which uses bit shifts.
7af7236 Add missing headers.
74e3a86 Remove the dependency to Serial. The sub class can assign this pointer when needed.
b7cbcf6 License change to MIT
c708654 Merge pull request sarfata#34 from denravonska/message-setter-bugfix
7f4a82b Fix an issue where setting single- and multi frame messages always reverted back to default messages.
1889ab9 Merge pull request sarfata#30 from KimBP/master
3560f1c Merge pull request sarfata#29 from adwuk/master
c5f3d76 added support for PGN 127258 - magnetic variation
3d06610 N2kMessages: Added parsing of PGN129025 (PositionRapid)
2905054 N2kCANMsg: Proper C++ style initialization of class members
1bce0c5 N2kMessages: Fix COG and SOG parsing in PGN129026
dd5fca3 N2kMessages: msToKnots() added
5d93a44 Merge pull request sarfata#26 from adwuk/master
f66c408 Added parsing of PGN 130311
9672b37 Merge pull request sarfata#3 from ttlappalainen/master
7d568f8 Merge pull request sarfata#24 from sarfata/patch-1
65f36bd Fix typo in documentation for SetN2kSystemTime

git-subtree-dir: lib/NMEA2000
git-subtree-split: f51b8ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants