Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to configure the orientation of KBox in my boat #64

Open
sarfata opened this issue Nov 23, 2017 · 4 comments
Open

As a user, I want to configure the orientation of KBox in my boat #64

sarfata opened this issue Nov 23, 2017 · 4 comments
Labels

Comments

@sarfata
Copy link
Owner

sarfata commented Nov 23, 2017

See work by @ronzeiller here:
https://github.com/ronzeiller/kbox-firmware-teensy36/commit/e5ba6a3ce79cb01102524898e0d53f846a6e21e7

@ronzeiller
Copy link
Contributor

What do you think
Is it better to do with the setting on axis or to calculate the Euler as you did it?
I think we should not mix up the methods and find a low cpu consuming way.

@sarfata
Copy link
Owner Author

sarfata commented Nov 27, 2017

I asked myself the same question but I did not see any benefit to make the change in the axis. We probably still need some post-processing so I think it's better to do everything in the driver because it is easier to read and understand than changing the axis.

The only exception would be if we wanted to support KBox flat on the ground or the ceiling, or installed sideways but nobody has mentioned this yet. I don't think we need to support this now.

@ronzeiller
Copy link
Contributor

I asked myself the same question but I did not see any benefit to make the change in the axis. We probably still need some post-processing so I think it's better to do everything in the driver because it is easier to read and understand than changing the axis.

driver?
Do you mean the library or the IMUService?

The only exception would be if we wanted to support KBox flat on the ground or the ceiling, or installed sideways but nobody has mentioned this yet. I don't think we need to support this now.

I have to put my KBox flat with the left side to the bow....

@sarfata
Copy link
Owner Author

sarfata commented Nov 28, 2017

Driver: I meant the library. That is what I call the driver. Sorry.

I have to put my KBox flat with the left side to the bow....

Ah ah ah. Making things hard on purpose! Let's do some testing to see what is required to support it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants