Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes submitted by Ron aka rescotti47 #61

Open
wants to merge 1 commit into
base: kbox-v0
Choose a base branch
from

Conversation

sarfata
Copy link
Owner

@sarfata sarfata commented Nov 23, 2017

This includes all the changes that Ron did for his own boat. I will be using this to make sure the develop branch does everything Ron needs:

Summary of all the changes and link to ticket to implement this in "official" KBox:

sarfata added a commit that referenced this pull request Dec 10, 2017
6835188 Merge pull request #61 from sarfata/do-not-redefine-bit
ab2b499 Merge pull request #60 from sarfata/seasmart-converter
6d6fe93 Do not redefine macro BIT(x) if already defined
e657718 Add link to seasmart protocol doc
74765f9 make cmake.sh executable
20b4db0 add travis config
a6ada78 Implemented Seasmart conversions
a3ba1fd Set up a test folder with Catch and cmake based build

git-subtree-dir: lib/NMEA2000
git-subtree-split: 6835188
@sarfata sarfata changed the base branch from master to kbox-v0 December 10, 2017 05:26
@CaptainRon47
Copy link

I am not sure how I can help you with this, all of my changes were adhoc and not conforming with any coding rules (oh well, they worked for me). . It looks like you are already addressing many of my changes in the IMU branch (at least the ones with IMU setup, new display page and location of 'constants'). This PR could address how tell Kbox what data to write to the various outputs. My thoughts would be that somewhere in the new config repository we set flags that would define what gets output at; the USB, the SD card, the WiFi and the NMEA outputs. So for me the N2K_USB_Flag would be off. I also turned off DeBug, so the DeBug_USB_Flag would be off. while the NM83_USB_FLag would be on. At least that would be my naive way of doing it.
I guess I will start by locating all my changes in the current (12/13/17) Master.

@CaptainRon47
Copy link

Well, I have started to go thru the new Master and while I am pretty confused I am picking up some things. I see that the encoder switch does have rotation options (A/B) not just the push button, you have gone to a logging approach for DEBUG, INFO and ERROR (but I don't yet understand how this works). I also found in the MFG section the NMEATest.h which shows me that to turn on the NMEA1/2 outputs i need to put a '1' in the digitalWrite statement. I tried that in my edits, but never did see any output on those pins.

I feel a bit like I am back at square one for making my changes, but at least I have my previous build which is doing more or less what I wanted it to do. I am still not sure how I can help you with rewriting this code, but at least you have my inputs.

@sarfata
Copy link
Owner Author

sarfata commented Dec 14, 2017

@CaptainRon47,

I created this pull-request so I have an easy way to look at all the changes you had done and make sure we cover all of them in the new master. I was not expecting you to go do the same changes again, I will do that for you. As you said, the big value here is showing me what is useful for you! And showing me how you solved it which always makes things a bit easier to do.

thomas

@CaptainRon47
Copy link

Thanks, I was just trying to see if I could help, but I am afraid I am out of my league (at my current level of C++ understanding) for writing modern efficient code! So I will be patient and wait and see where you go with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants