Merge pull request #80 from sarugaku/fix-normalization

Dont canonicalize named requirement lines
sarugaku · Oct 9, 2018 · b19a402 · b19a402
2 parents 79c8b9a + d43d164
commit b19a402
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/news/79.bugfix b/news/79.bugfix
@@ -0,0 +1 @@
+Fixed a bug in named requirement normalization which caused querying the index to fail when looking up requirements with dots in their names.
diff --git a/src/requirementslib/models/requirements.py b/src/requirementslib/models/requirements.py
@@ -96,7 +96,10 @@ def from_pipfile(cls, name, pipfile):
 
     @property
     def line_part(self):
-        return "{0}".format(canonicalize_name(self.name))
+        # FIXME: This should actually be canonicalized but for now we have to
+        # simply lowercase it and replace underscores, since full canonicalization
+        # also replaces dots and that doesn't actually work when querying the index
+        return "{0}".format(self.name.lower().replace("_", "-"))
 
     @property
     def pipfile_part(self):