Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the docstrings for providers.py #138

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Clarify the docstrings for providers.py #138

merged 1 commit into from
Sep 11, 2023

Conversation

brettcannon
Copy link
Contributor

Closes #137

This was referenced Sep 8, 2023
Closed
Open
pradyunsg
pradyunsg approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for @uranusjr since it's definitely possible that there's a gap in my understanding. :)

@uranusjr uranusjr merged commit 69d9fee into sarugaku:main Sep 11, 2023
7 checks passed
@brettcannon brettcannon deleted the clarify-docstrings branch September 11, 2023 22:36
@notatallshaw notatallshaw mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Awkward wording in docstring for find_matches()
3 participants
@brettcannon @pradyunsg @uranusjr