Merge pull request #53 from vsvastey/usr/vsvastey/switchstmt

feat: add check HTTP Method and HTTP Status is SwitchStmt

pkg/analyzer/analyzer.go

@@ -54,6 +54,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
 		(*ast.BasicLit)(nil),
 		(*ast.CompositeLit)(nil),
 		(*ast.IfStmt)(nil),
+		(*ast.SwitchStmt)(nil),
 	}
 
 	insp.Preorder(filter, func(node ast.Node) {
@@ -224,6 +225,43 @@ func run(pass *analysis.Pass) (interface{}, error) {
 
 				checkHTTPMethod(pass, basicLit)
 			}
+
+		case *ast.SwitchStmt:
+			selectorExpr, ok := n.Tag.(*ast.SelectorExpr)
+			if !ok {
+				return
+			}
+
+			var checkFunc func(pass *analysis.Pass, basicLit *ast.BasicLit)
+
+			switch selectorExpr.Sel.Name {
+			case "StatusCode":
+				if !lookupFlag(pass, HTTPStatusCodeFlag) {
+					return
+				}
+				checkFunc = checkHTTPStatusCode
+			case "Method":
+				if !lookupFlag(pass, HTTPMethodFlag) {
+					return
+				}
+				checkFunc = checkHTTPMethod
+			default:
+				return
+			}
+
+			for _, stmt := range n.Body.List {
+				caseClause, ok := stmt.(*ast.CaseClause)
+				if !ok {
+					continue
+				}
+				for _, expr := range caseClause.List {
+					basicLit, ok := expr.(*ast.BasicLit)
+					if !ok {
+						continue
+					}
+					checkFunc(pass, basicLit)
+				}
+			}
 		}
 	})
 

pkg/analyzer/internal/template/test-httpmethod.go.tmpl

@@ -63,3 +63,23 @@ func _() error {
     return nil
 }
 {{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var r http.Request
+    switch r.Method {
+    case "{{ $key }}": // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+      return
+    }
+}
+{{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var r http.Request
+    switch r.Method {
+    case {{ $value }}:
+      return
+    }
+}
+{{ end -}}

pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl

@@ -126,3 +126,24 @@ func _() {
     http.RedirectHandler("", {{ $value }})
 }
 {{ end -}}
+
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var resp http.Response
+    switch resp.StatusCode {
+    case {{ $key }}: // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+      return
+    }
+}
+{{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var resp http.Response
+    switch resp.StatusCode {
+    case {{ $value }}:
+      return
+    }
+}
+{{ end -}}