Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SchemaConverter interface for controlling Schema generation #160

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

asafbennatan
Copy link
Contributor

solves #159

1.added SchemaConverter interface for controlling Schema generation
2.added DefaultSchemaConverter for running the default (same logic that we had before in JsonSchemaUtil) - note this also improves performance as previously schema creator was created per serialization
3. JsonSchemaUtil is not really necessary anymore but kept to be compatible;

Copy link
Owner

@sashirestela sashirestela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sashirestela sashirestela linked an issue Jul 19, 2024 that may be closed by this pull request
added SchemaConverter interface for controlling Schema generation from classes
@asafbennatan
Copy link
Contributor Author

asafbennatan commented Jul 19, 2024

@sashirestela fixed formatting , anything else ?

@sashirestela
Copy link
Owner

sashirestela commented Jul 20, 2024

@asafbennatan
Copy link
Contributor Author

@sashirestela done , please review

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (5db4c2c) to head (4d3fbb0).

Files Patch % Lines
...restela/openai/support/DefaultSchemaConverter.java 87.50% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     89.62%   89.71%   +0.08%     
- Complexity      697      700       +3     
============================================
  Files           101      102       +1     
  Lines          1465     1468       +3     
  Branches         31       31              
============================================
+ Hits           1313     1317       +4     
+ Misses          107      106       -1     
  Partials         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashirestela sashirestela merged commit 064c11b into sashirestela:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a way to customize JsonSchemaUtil
4 participants