Only run framework checks when deploying (#1493)

We expect these checks to succeed almost all the time, and we really only need them as a backstop to ensure we don't deploy a change that breaks real-world users.
sass · Sep 18, 2021 · e3370e6 · e3370e6
1 parent 6a9cfc8
commit e3370e6
Showing 1 changed file with 29 additions and 25 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -194,9 +194,29 @@ jobs:
           --errors ambiguous-doc-reference,broken-link,deprecated
           --errors unknown-directive,unknown-macro,unresolved-doc-reference
 
+  double_check:
+    name: Double-check
+    runs-on: ubuntu-latest
+    needs:
+    - sass_spec_language
+    - sass_spec_js
+    - dart_tests
+    - node_tests
+    - static_analysis
+    - dartdoc
+    if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: dart-lang/setup-dart@v1
+      - run: dart pub get
+      - name: Run checks
+        run: dart pub run grinder sanity-check-before-release
+
   bootstrap:
     name: "Bootstrap ${{ matrix.bootstrap_version }}"
     runs-on: ubuntu-latest
+    needs: [double_check]
 
     strategy:
       fail-fast: false
@@ -215,6 +235,7 @@ jobs:
   bourbon:
     name: Bourbon
     runs-on: ubuntu-latest
+    needs: [double_check]
 
     steps:
       - uses: actions/checkout@v2
@@ -230,6 +251,7 @@ jobs:
   foundation:
     name: Foundation
     runs-on: ubuntu-latest
+    needs: [double_check]
 
     steps:
       - uses: actions/checkout@v2
@@ -246,6 +268,7 @@ jobs:
   bulma:
     name: Bulma
     runs-on: ubuntu-latest
+    needs: [double_check]
 
     steps:
       - uses: actions/checkout@v2
@@ -256,29 +279,10 @@ jobs:
       - name: Build
         run: dart bin/sass.dart --quiet build/bulma/bulma.sass build/bulma-output.css
 
-  double_check:
-    name: Double-check
-    runs-on: ubuntu-latest
-    needs:
-    - sass_spec_language
-    - sass_spec_js
-    - dart_tests
-    - node_tests
-    - static_analysis
-    - dartdoc
-    if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
-
-    steps:
-      - uses: actions/checkout@v2
-      - uses: dart-lang/setup-dart@v1
-      - run: dart pub get
-      - name: Run checks
-        run: dart pub run grinder sanity-check-before-release
-
   deploy_github_linux:
     name: "Deploy Github: Linux"
     runs-on: ubuntu-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps:
@@ -326,7 +330,7 @@ jobs:
   deploy_npm:
     name: Deploy npm
     runs-on: ubuntu-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps:
@@ -361,7 +365,7 @@ jobs:
   deploy_pub:
     name: "Deploy Pub"
     runs-on: ubuntu-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps:
@@ -394,7 +398,7 @@ jobs:
   deploy_homebrew:
     name: "Deploy Homebrew"
     runs-on: ubuntu-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps:
@@ -410,7 +414,7 @@ jobs:
   deploy_chocolatey:
     name: "Deploy Chocolatey"
     runs-on: windows-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps:
@@ -424,7 +428,7 @@ jobs:
   deploy_website:
     name: "Deploy sass-lang.com"
     runs-on: ubuntu-latest
-    needs: [double_check]
+    needs: [bootstrap, bourbon, foundation, bulma]
     if: "startsWith(github.ref, 'refs/tags/') && github.repository == 'sass/dart-sass'"
 
     steps: