Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #1535

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Improve performance #1535

merged 6 commits into from
Oct 21, 2021

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 16, 2021

Closes #1534

@nex3 nex3 requested a review from jathak October 16, 2021 00:29
@nex3 nex3 mentioned this pull request Oct 16, 2021
Closed
@nex3 nex3 force-pushed the perf branch 2 times, most recently from b4e473c to 1b82f0b Compare October 19, 2021 20:57
jathak
jathak approved these changes Oct 20, 2021
View reviewed changes
lib/src/value/string.dart Show resolved Hide resolved
perf.md Show resolved Hide resolved
@nex3
Replace Susy with Carbon as a benchmark target
0ce65fc 
Neither of these support Node v16 yet, but Susy is unmaintained and
will never support it while Carbon will likely add support in the near
future.
@nex3
Update benchmarks
fa25764
@nex3
Cache hash codes for Sass strings and numbers
6069708 
These values are often stored in maps, so caching their hash codes
seems to be net valuable.
@nex3
Cache relative import results as well as absolute ones
d13a38e 
This dramatically improves the performance of a sample app using the
Carbon design system, and should generally improve apps that have a
lot of repeated @imports of library files. It's possible we can back
this out if it's not pulling its weight once we no longer support
@import.
@nex3
Avoid creating zone variables inside _EvaluateVisitor
2430ac6 
Instead, we create a single zone-scoped object that's visible for the
entire lifespan of the visitor, and which exposes evaluation internals
which can be updated as direct field modifications.
@nex3
Update benchmarks
86b16f5
@nex3 nex3 merged commit 435e1b2 into main Oct 21, 2021
@nex3 nex3 deleted the perf branch October 21, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

16x performance difference between sass and node-sass
2 participants
@nex3 @jathak