Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track missing alpha channels in colors #2051

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Track missing alpha channels in colors #2051

merged 2 commits into from
Aug 22, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Aug 1, 2023

@nex3 nex3 requested a review from Goodwine August 1, 2023 21:37
Goodwine
Goodwine reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing no CHANGELOG was added because this is a feature branch, but should there be tests anywhere for these?

lib/src/value/color.dart Show resolved Hide resolved
@nex3
Copy link
Contributor Author

nex3 commented Aug 1, 2023

I'm guessing no CHANGELOG was added because this is a feature branch, but should there be tests anywhere for these?

We're working on tests separately in the feature branch of the sass-spec repo, but because the tests are fairly holistic we're getting the implementation mostly in-place first.

@Goodwine Goodwine self-requested a review August 1, 2023 23:32
@nex3 nex3 merged commit c273c45 into feature.color-4 Aug 22, 2023
45 checks passed
@nex3 nex3 deleted the missing-alpha branch August 22, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @Goodwine