-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into feature.color-4 #2054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make better use of cli_pkg
The previous token didn't seem to be recognized. See https://travis-ci.com/github/sass/dart-sass-embedded/jobs/364028782. It's unclear why it didn'twork, but I'm hoping regenerating fixes it.
I realized the problem: this repo uses travis-ci.com, not travis-ci.org, but the Travis CLI defaults to encrypting using .com credentials. This time I regenerated the token using --pro, which should work.
(As per the protocol spec)
Partially addresses sass/embedded_protocol#37
Fix broken tests
Goodwine
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I can provide any feedback on this, except that CI is failing, so I'll stamp :)
This allows us to reserve null to indicate a missing alpha channel instead in future versions.
* Sqrt calc function implementation * Pow calc function * Calc round function * Corrections and rename parameter to inLegacySassFunction * Unary calc functions * Arguments with no units correction * Refactor round function * Update modulo function to return SassNumber and corrections * Round accepting fake units fix * Up/Down round strategy fix * Return incompatible message fix
* Bump http from 0.13.6 to 1.1.0 Bumps [http](https://github.com/dart-lang/http/tree/master/pkgs) from 0.13.6 to 1.1.0. - [Release notes](https://github.com/dart-lang/http/releases) - [Commits](https://github.com/dart-lang/http/commits/http-v1.1.0/pkgs) --- updated-dependencies: - dependency-name: http dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update pubspec.yaml Co-authored-by: なつき <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos (Goodwine) <[email protected]> Co-authored-by: なつき <[email protected]>
This reverts commit bb24476.
This reverts commit e4c8cd6.
Revert new calculation functions
Fix for Anchor Mac and Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1929
See sass/embedded-host-node#243