Implement access tracking for containingUrl #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
access-containing-url
branch
5 times, most recently
from
8b90f10
to
71370a3
Compare
ntkme
force-pushed
the
access-containing-url
branch
from
71370a3
to
bdd0191
Compare
ntkme
force-pushed
the
access-containing-url
branch
2 times, most recently
from
f0336f7
to
c467ae7
Compare
nex3
requested changes
Apr 12, 2024
nex3
reviewed
Apr 12, 2024
ntkme
force-pushed
the
access-containing-url
branch
4 times, most recently
from
d6979b9
to
5929113
Compare
ntkme
force-pushed
the
access-containing-url
branch
from
5929113
to
3ddea86
Compare
nex3
requested changes
Apr 17, 2024
ntkme
force-pushed
the
access-containing-url
branch
from
1e86303
to
372c560
Compare
ntkme
force-pushed
the
access-containing-url
branch
from
372c560
to
10f9657
Compare
nex3
approved these changes
Apr 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CanonicalizeContextclass in dart which is able to track ifcontainingUrlis accessed or not, it also changes the dart2jsJSCanonicalizeContextclass to be a wrapper, so that the containingUrl in JS would lazily access the dartcontainingUrlmethod instead of eagerly during construction. Finally for embedded host, this adds acontainingUrlWithoutMarkingmethod that allow the serialization of embedded protocol without marking, and we can mark it accordingly depends on the result from host.sass/sass#3835
sass/embedded-host-node#285